Skip to content

chore: avoid slow tests in AGENTS.md #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wemeetagain wants to merge 1 commit into from
Closed

chore: avoid slow tests in AGENTS.md #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ implementation was primarily AI-authored or whether AI was used only for codebas
### Pre-push checklist

1. `zig fmt --check .`
2. `zig build test`
2. Run relevant tests, avoid slow `zig build test` unless necessary

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile the conflicting pre-push test requirements

When an agent decides which tests to run before pushing, this checklist now says to avoid zig build test, while the Critical rules still require that exact command before every push. The higher-priority instruction therefore defeats this change's stated purpose and leaves contributors with contradictory guidance. Update both requirements together so the full suite is either mandatory or explicitly conditional.

AGENTS.md reference: AGENTS.md:L6-L7

Useful? React with 👍 / 👎.

@spiral-ladder spiral-ladder Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can be more specific? Not sure about exact wording, but i prefer stronger words like 'never'

Suggested change
2. Run relevant tests, avoid slow `zig build test` unless necessary
2. Run relevant tests, never run slow `zig build test` unless changes touch spec logic

3. Relevant spec tests for consensus, SSZ, or BLS changes
4. `pnpm lint` for binding source changes
5. Rebuild bindings and run `pnpm test` for binding or NAPI changes
Expand Down
Loading