chore: avoid slow tests in AGENTS.md - #544
wemeetagain wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d9e2a0682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| 1. `zig fmt --check .` | ||
| 2. `zig build test` | ||
| 2. Run relevant tests, avoid slow `zig build test` unless necessary |
There was a problem hiding this comment.
When an agent decides which tests to run before pushing, this checklist now says to avoid zig build test, while the Critical rules still require that exact command before every push. The higher-priority instruction therefore defeats this change's stated purpose and leaves contributors with contradictory guidance. Update both requirements together so the full suite is either mandatory or explicitly conditional.
AGENTS.md reference: AGENTS.md:L6-L7
Useful? React with 👍 / 👎.
spiral-ladder
left a comment
spiral-ladder
left a comment
There was a problem hiding this comment.
lgtm with an optional comment, not sure which one is better, we can test things out
|
|
||
| 1. `zig fmt --check .` | ||
| 2. `zig build test` | ||
| 2. Run relevant tests, avoid slow `zig build test` unless necessary |
There was a problem hiding this comment.
maybe we can be more specific? Not sure about exact wording, but i prefer stronger words like 'never'
| 2. Run relevant tests, avoid slow `zig build test` unless necessary | |
| 2. Run relevant tests, never run slow `zig build test` unless changes touch spec logic |
|
@nflaig @spiral-ladder can one of you take over / reopen the PR? I don't have my gpg key on this machine? |
github-project-automation
Bot
moved this from In Progress
to Done
in Lodestar Team Coordination
|
closing in favor of #546 |
3 participants
We shouldn't require running the full spec test suite locally for every PR.