consensus/babe: load BABE authorities from genesis#603
Merged
noot merged 27 commits intodevelopmentfrom Feb 15, 2020
Merged
Conversation
DecodeCustom handles calling Decode function for types that have Decode defined, otherwise uses regular Scale Decoding functions Signed-off-by: edwardmack <ed@edwardmack.com>
Signed-off-by: edwardmack <ed@edwardmack.com>
…nSafe/gossamer into ed/525-custom-scale-methods
…o noot/genesis-auth
ryanchristo
reviewed
Feb 12, 2020
ryanchristo
approved these changes
Feb 13, 2020
Contributor
ryanchristo
left a comment
ryanchristo
left a comment
There was a problem hiding this comment.
Very nice. Looks good to me.
| msgRec <-chan p2p.Message // receive messages from p2p service | ||
| epochDone <-chan struct{} // receive from this channel when BABE epoch changes | ||
| msgSend chan<- p2p.Message // send messages to p2p service | ||
| babeAuthority bool |
Contributor
Author
There was a problem hiding this comment.
hmm, we might have an option for grandpaAuthority in the future, so I wanted to be a bit more specific. maybe isBabeAuthority?
Contributor
There was a problem hiding this comment.
Gotcha. Yea, maybe isBabeAuthority to imply a bool...? Might not be necessary though.
Contributor
There was a problem hiding this comment.
agree with the pattern is before the bool.
edwardmack
approved these changes
Feb 15, 2020
Contributor
edwardmack
left a comment
edwardmack
left a comment
There was a problem hiding this comment.
Excellent work, looks good to me.
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* update DecodeCustom to work inside of structs * fix decode of BabeConfiguration * set genesis authority data when spawning babe session from core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
depends on #597 #595
Tests:
Issues:
closes #598