codec; Enable custom scale methods#597
Merged
edwardmack merged 8 commits intodevelopmentfrom Feb 10, 2020
Merged
Conversation
DecodeCustom handles calling Decode function for types that have Decode defined, otherwise uses regular Scale Decoding functions Signed-off-by: edwardmack <ed@edwardmack.com>
edwardmack
requested review from
ansermino,
noot,
ryanchristo and
thomasmodeneis
Signed-off-by: edwardmack <ed@edwardmack.com>
…nSafe/gossamer into ed/525-custom-scale-methods
| github.com/disiqueira/gotree v1.0.0 | ||
| github.com/ethereum/go-ethereum v1.9.6 | ||
| github.com/filecoin-project/go-leb128 v0.0.0-20190212224330-8d79a5489543 | ||
| github.com/golang/protobuf v1.3.2 // indirect |
Contributor
There was a problem hiding this comment.
I have raised https://github.com/ChainSafe/gossamer/wiki/GoMOD#pr-597 to track the gomod changes for this PR. Lets try to keep it updated for the next changes.
thomasmodeneis
approved these changes
Feb 10, 2020
Contributor
thomasmodeneis
left a comment
thomasmodeneis
left a comment
There was a problem hiding this comment.
Looks good, I have added a comment on the go.mod changes to track the changes, other than that it looks good.
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* checks if type has Encode function * Added DecodeCustom to handle calling Decode func DecodeCustom handles calling Decode function for types that have Decode defined, otherwise uses regular Scale Decoding functions Signed-off-by: edwardmack <ed@edwardmack.com> * go fmt'ed Signed-off-by: edwardmack <ed@edwardmack.com> * fixed lint rants Signed-off-by: edwardmack <ed@edwardmack.com> Co-authored-by: noot <36753753+noot@users.noreply.github.com>
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality for handling custom Encode/Decode function for types when these functions have been defined.
Changes
Tests:
Issues:
closes #525