Skip to content

fix: link check curiostorage.org#6328

Merged
LesnyRumcajs merged 1 commit intomainfrom
fix-linkcheck
Dec 10, 2025
Merged

fix: link check curiostorage.org#6328
LesnyRumcajs merged 1 commit intomainfrom
fix-linkcheck

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Dec 10, 2025

Summary of changes

Changes introduced in this pull request:

  • seems to be constantly timing out, even though it works fine on my end. Perhaps some bot protection.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated domain exclusion configuration to improve link checking stability and prevent timeout-related issues.

✏️ Tip: You can customize this high-level summary in your review settings.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner December 10, 2025 15:28
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team December 10, 2025 15:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 10, 2025

Walkthrough

Added a domain exclusion entry to the lychee link checker configuration to skip timeouts. The change extends the exclude list in .config/lychee.toml by adding "curiostorage.org" with a comment noting frequent timeouts.

Changes

Cohort / File(s) Summary
Link checker configuration
\.config/lychee\.toml
Added "curiostorage.org" to the exclude list with comment "Frequent timeouts" to prevent bot protection timeouts during link verification

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • elmattic
  • hanabi1224
  • akaladarshi

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly matches the main change: adding 'curiostorage.org' to the exclude list in the link checker configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-linkcheck

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f76faaa and 7654487.

📒 Files selected for processing (1)
  • .config/lychee.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: LesnyRumcajs
Repo: ChainSafe/forest PR: 5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: All lint checks
🔇 Additional comments (1)
.config/lychee.toml (1)

28-29: LGTM!

The exclusion entry follows the established pattern in the configuration, with a clear comment explaining the rationale. This is a pragmatic approach to prevent CI timeouts from an external service outside your control.


Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 825a4ea Dec 10, 2025
41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-linkcheck branch December 10, 2025 16:21
@coderabbitai coderabbitai Bot mentioned this pull request Feb 4, 2026
6 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants