Skip to content

fix: ignore ubuntu link checks#6021

Merged
hanabi1224 merged 1 commit intomainfrom
fix-ubuntu-link
Sep 2, 2025
Merged

fix: ignore ubuntu link checks#6021
hanabi1224 merged 1 commit intomainfrom
fix-ubuntu-link

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Sep 2, 2025

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated link-checker configuration to exclude the domain “ubuntu.com,” reducing false-positive failures during automated link checks.
    • Added a clarifying comment noting the likely cause (bot protection/404 in checker while working in browser).
    • Kept all other link-checker settings unchanged (timeouts, retry counts, and wait times).

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner September 2, 2025 08:52
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and elmattic and removed request for a team September 2, 2025 08:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 2, 2025

Walkthrough

Added a new domain exclusion to Lychee configuration: appended "ubuntu.com" to the exclude list in .config/lychee.toml with a clarifying comment. No other configuration values changed.

Changes

Cohort / File(s) Summary
Lychee config exclude update
.config/lychee.toml
Added comment about bot protection/404 and appended "ubuntu.com" to the exclude array; no changes to timeout, max_retries, or retry_wait_time.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • elmattic
  • akaladarshi

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8ff95b3 and c669cf0.

📒 Files selected for processing (1)
  • .config/lychee.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: LesnyRumcajs
PR: ChainSafe/forest#5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
🔇 Additional comments (2)
.config/lychee.toml (2)

24-25: Pragmatic exclusion to unblock CI — LGTM.

Adding ubuntu.com to the Lychee exclude list is a reasonable mitigation for bot protection flakiness.


24-25: Verify ubuntu.com occurrences for regex coverage
rg returned no matches; manually inspect the repo for any “ubuntu.com” references (including subdomains) to ensure the proposed regex ^https?://([^.]+\.)?ubuntu\.com(/|$) covers every case.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-ubuntu-link

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@hanabi1224 hanabi1224 added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit a627763 Sep 2, 2025
44 checks passed
@hanabi1224 hanabi1224 deleted the fix-ubuntu-link branch September 2, 2025 10:21
@coderabbitai coderabbitai Bot mentioned this pull request Dec 10, 2025
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 4, 2026
6 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants