Skip to content

chore: bump the pubsub validation queue length to 256 #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanabi1224 merged 3 commits into from
Jun 18, 2025
+18 −1
Merged

chore: bump the pubsub validation queue length to 256 #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ecb96
chore: bump the pubsub validation queue length to 4096
hanabi1224 Jun 17, 2025
614ec88
queue size 256
hanabi1224 Jun 18, 2025
b1a0503
Merge remote-tracking branch 'origin/main' into hm/go-f3-pubsub-config
hanabi1224 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion f3-sidecar/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ require (
github.com/libp2p/go-libp2p-kad-dht v0.33.1
github.com/libp2p/go-libp2p-pubsub v0.14.0
github.com/stretchr/testify v1.10.0
golang.org/x/crypto v0.39.0
)

require (
Expand Down Expand Up @@ -135,7 +136,6 @@ require (
go.uber.org/mock v0.5.2 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.27.0 // indirect
golang.org/x/crypto v0.39.0 // indirect
golang.org/x/exp v0.0.0-20250606033433-dcc06ee1d476 // indirect
golang.org/x/mod v0.25.0 // indirect
golang.org/x/net v0.41.0 // indirect
Expand Down
17 changes: 17 additions & 0 deletions f3-sidecar/p2p.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ import (
"github.com/libp2p/go-libp2p"
dht "github.com/libp2p/go-libp2p-kad-dht"
pubsub "github.com/libp2p/go-libp2p-pubsub"
pubsub_pb "github.com/libp2p/go-libp2p-pubsub/pb"
"github.com/libp2p/go-libp2p/core/host"
"github.com/libp2p/go-libp2p/core/protocol"
"golang.org/x/crypto/blake2b"
)

const ListenAddr = "/ip4/127.0.0.1/tcp/0"
Expand Down Expand Up @@ -51,10 +53,25 @@ func createP2PHost(ctx context.Context, networkName string) (*P2PHost, error) {
ps, err := pubsub.NewGossipSub(ctx, host,
pubsub.WithPeerExchange(true),
pubsub.WithFloodPublish(true),
pubsub.WithMessageIdFn(hashMsgId),
// Bump the validation queue to accommodate the increase in gossipsub message
// exchange rate as a result of f3. The size of 256 should offer enough headroom
// for slower F3 validation while avoiding: 1) avoid excessive memory usage, 2)
// dropped consensus related messages and 3) cascading effect among other topics
// since this config isn't topic-specific.
//
// Note that the worst case memory footprint is 256 MiB based on the default
// message size of 1 MiB, which isn't overridden in Lotus.
pubsub.WithValidateQueueSize(256),
pubsub.WithPeerScore(PubsubPeerScoreParams, PubsubPeerScoreThresholds))
if err != nil {
return nil, err
}

return &P2PHost{host, hostDHT, backupHostDHT, ps}, nil
}

func hashMsgId(m *pubsub_pb.Message) string {
hash := blake2b.Sum256(m.Data)
return string(hash[:])
}
Loading