Skip to content

chore: bump the pubsub validation queue length to 256#5742

Merged
hanabi1224 merged 3 commits intomainfrom
hm/go-f3-pubsub-config
Jun 18, 2025
Merged

chore: bump the pubsub validation queue length to 256#5742
hanabi1224 merged 3 commits intomainfrom
hm/go-f3-pubsub-config

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Jun 17, 2025

Summary of changes

Ports filecoin-project/lotus#13176

Changes introduced in this pull request:

  • Ports WithMessageIdFn as well. (This was introduced 5 years ago in Lotus and is not made for F3, porting it just to get parity)

Reference issue to close (if applicable)

Closes #5743

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review June 17, 2025 05:40
@hanabi1224 hanabi1224 requested a review from a team as a code owner June 17, 2025 05:40
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team June 17, 2025 05:40
sudo-shashank
sudo-shashank previously approved these changes Jun 17, 2025
LesnyRumcajs
LesnyRumcajs previously approved these changes Jun 17, 2025
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this also ports the WithMessageIdFn; it'd be nice to include this at least in this PR title or description to facilitate future archaeology.

Q: what's the effect on the node if either of those changes are not ported?

@masih
Copy link
Copy Markdown

masih commented Jun 17, 2025

Please note, we are investigating what the smallest effective size can be for validation queue size.

Please do not merge this PR until this is determined for Lotus in the corresponding PR.

@hanabi1224 hanabi1224 dismissed stale reviews from LesnyRumcajs and sudo-shashank via b1a0503 June 18, 2025 01:02
@hanabi1224 hanabi1224 changed the title chore: bump the pubsub validation queue length to 4096 chore: bump the pubsub validation queue length to 256 Jun 18, 2025
@hanabi1224 hanabi1224 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit f111dc1 Jun 18, 2025
56 checks passed
@hanabi1224 hanabi1224 deleted the hm/go-f3-pubsub-config branch June 18, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go-f3] pubsub deliveries queue full (len=128)

4 participants