chore: bump the pubsub validation queue length to 256#5742
Merged
hanabi1224 merged 3 commits intomainfrom Jun 18, 2025
Merged
Conversation
sudo-shashank
previously approved these changes
Jun 17, 2025
LesnyRumcajs
previously approved these changes
Jun 17, 2025
Member
LesnyRumcajs
left a comment
There was a problem hiding this comment.
nit: this also ports the WithMessageIdFn; it'd be nice to include this at least in this PR title or description to facilitate future archaeology.
Q: what's the effect on the node if either of those changes are not ported?
|
Please note, we are investigating what the smallest effective size can be for validation queue size. Please do not merge this PR until this is determined for Lotus in the corresponding PR. |
b1a0503
LesnyRumcajs
approved these changes
Jun 18, 2025
sudo-shashank
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ports filecoin-project/lotus#13176
Changes introduced in this pull request:
WithMessageIdFnas well. (This was introduced 5 years ago in Lotus and is not made for F3, porting it just to get parity)Reference issue to close (if applicable)
Closes #5743
Other information and links
Change checklist