Fix uniform name for scaling clearcoat normals #12054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
|
Fantastic, thanks @jjhembd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in #12018, which added support for scaling of normal textures. The uniform name for scaling a clearcoat normal texture was incorrect.
Issue number and link
Fixes #12051.
Testing plan
Run
ModelSpeclocally.Author checklist
CONTRIBUTORS.md[ ] I have updatedThis is fixing something that was introduced AFTER the last release.CHANGES.mdwith a short summary of my change[ ] I have added or updated unit tests to ensure consistent code coverage[ ] I have updated the inline documentation, and included code examples where relevant