fix: Enable Snowflake tool calling via Responses API - #58
Merged
Conversation
- Add PAT token detection with pat/ prefix handling - Strip pat/ prefix and set PROGRAMMATIC_ACCESS_TOKEN header type - Add custom streaming handler for Claude models missing 'created' field
- Fix tool_choice transformation and defaulting - Add streaming handler and tool_use response transformation - Complete message format with content + content_list fields
Resolved conflicts by: - Keeping both message transformation tests and streaming handler tests - Using SnowflakeStreamingHandler (with tool_use transformation) instead of SnowflakeChatCompletionStreamingHandler - Adding get_model_response_iterator method to return custom streaming handler
Fixes "content or contentList must be provided" error when using previous_response_id to continue conversations after tool execution. Problem: Snowflake/Claude creates empty assistant messages (content: None or "") when deciding to only call tools, resulting in consecutive assistant messages. When these are loaded from session history, they fail Snowflake's validation requiring either content or content_list. Solution: - Added _filter_empty_assistant_messages() method to remove assistant messages with no content and no tool_calls - Applied filtering to all session loading paths (Redis and spend logs) - Applied filtering to Redis storage to prevent storing empty messages This ensures conversation history is clean regardless of whether it's loaded from Redis (fast path) or spend logs (fallback path).
Fixes CI test failures:
1. Change empty content placeholder from space " " to empty string ""
- Snowflake accepts empty string as valid content
- Tests expect "" for None content normalization
2. Update tool_choice test to expect object format
- Snowflake requires tool_choice as objects: {"type": "auto"}
- String format caused "invalid request" errors in production
- Test now validates correct transformation behavior
These changes ensure tests match the working production behavior.
3 tasks
mateo-di
added a commit
that referenced
this pull request
Feb 10, 2026
…, #58 Port 5 CARTO features that were silently dropped during the v1.81.0 upstream sync due to class hierarchy refactoring: - Add SnowflakeStreamingHandler for missing 'created' field and Claude-format tool_use -> OpenAI tool_calls transformation - Add _transform_messages() for role="tool" -> Snowflake content_list - Enhance _transform_tool_choice() to convert strings to Snowflake object format (e.g. "auto" -> {"type": "auto"}) - Add get_model_response_iterator() override - Default tool_choice to "auto" when tools present in Responses API Also adds .github/carto-features.yml manifest to track critical customizations and prevent future sync regressions.
mateo-di
added a commit
that referenced
this pull request
Feb 10, 2026
Static registry of critical CARTO customizations that must survive upstream syncs. The resolver should verify all patterns exist after every sync to prevent silent feature regressions (like the OCI Gemini and Snowflake tool calling drops in v1.81.0). Tracks: OCI Gemini (#68), Snowflake streaming/tool calling (#38, #58), Azure URL stripping (#70), JSON repair (#54), Redis sessions (#16).
3 tasks
3 tasks
This was referenced Apr 10, 2026
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Snowflake tool calling support for Responses API by fixing critical transformation issues.
Changes
tool_choice="auto"when tools present but not specified in Responses APItool_choiceformat transformation for Snowflake (string → object format)namefield fromtool_choicefor "auto" type (only for "required")tool_useto OpenAItool_callsformatcontentandcontent_listfieldsImpact
Enables full tool calling functionality for Snowflake Cortex via Responses API. Before these fixes:
After these fixes: All working ✅
Test Plan
tool_choicedefaulting logic🤖 Generated with Claude Code