Update poetry.lock - #16
Closed
miguelangelmorenochacon wants to merge 5 commits into
Closed
Conversation
extra body params passed to the request body
miguelangelmorenochacon
deleted the
carto/fix-vertex-ai-labels-not-forwarded
branch
October 27, 2025 14:23
mateo-di
added a commit
that referenced
this pull request
Feb 10, 2026
Static registry of critical CARTO customizations that must survive upstream syncs. The resolver should verify all patterns exist after every sync to prevent silent feature regressions (like the OCI Gemini and Snowflake tool calling drops in v1.81.0). Tracks: OCI Gemini (#68), Snowflake streaming/tool calling (#38, #58), Azure URL stripping (#70), JSON repair (#54), Redis sessions (#16).
3 tasks
mateo-di
added a commit
that referenced
this pull request
Jul 17, 2026
…ession storage The PR #121 conflict resolution took upstream's streaming_iterator.py __init__ (which has no litellm_completion_request param) while git auto-merged handler.py cleanly, keeping CARTO's call sites that pass litellm_completion_request= (PR #16, Redis session storage). Result: every streaming Responses API request raised TypeError: LiteLLMCompletionStreamingIterator.__init__() got an unexpected keyword argument 'litellm_completion_request' (3,079 occurrences in the cloud-native integration run for PR BerriAI#26437; 36 AI integration tests failed). The method body _store_session_in_redis also reads self.litellm_completion_request, which was never assigned. Restore the param and the attribute assignment exactly as on carto/main before the sync (7244577), with CARTO markers so future syncs see it.
mateo-di
added a commit
that referenced
this pull request
Jul 17, 2026
…andler Second dropped wiring from the PR #121 conflict resolution, subtler than the first: async_responses_api_session_handler lost the CARTO PATCH that reads sessions from Redis before the DB-backed store (PR #16). Both Redis helpers survived the merge, so manifest pattern greps passed, but _patch_get_session_from_redis was left orphaned - defined with zero call sites. Session writes (restored in 1c1f2a0) landed in Redis while reads went to the batch-delayed SpendLogs store, so immediate follow-up turns lost their conversation history. Observed blast radius in cloud-native PR BerriAI#26437 integration rerun: conversations answered with other conversations' content, ai-api agent loops spun (4,333 /responses calls in 13 minutes, ~25/min is normal), and the CI org burned through its 10M AI quota mid-run. Restore the Redis-first read exactly as on carto/main pre-sync, and add regression tests pinning the read-before-DB wiring so an orphaned helper can't silently pass future syncs.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement