chore(ci): add carto-features-check skill for manifest verification - #114
Merged
Conversation
Adds a committed project skill at .claude/skills/carto-features-check that: - runs the carto-features.yml grep-verify logic locally (mirrors CI), and - audits a branch diff for CARTO customizations missing a manifest entry, with guidance on picking stable verification patterns. Self-contained: carto-features-check.yml stays the CI source of truth; the skill carries its own copy of the verify loop for local use. Un-ignores .claude/skills/ in .gitignore so the skill ships with the fork while personal .claude settings remain ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a committed project skill at
.claude/skills/carto-features-check/that helps maintain.github/carto-features.yml— the CARTO features manifest that protects fork customizations from being silently dropped during upstream syncs.The skill does two jobs:
carto-features-check.ymllocally, so you catch a broken manifest before pushing and waiting on CI.carto/main...HEAD) for CARTO customizations that have no manifest entry, then guides adding one with a stable verification pattern.Honest scope note
There is no reliable machine marker for "this code is a CARTO customization" (only a fraction carry a
# CARTO:comment). So the coverage job is heuristic — it surfaces candidates from the diff and relies on judgment. The skill is explicit about this and never claims full coverage.Design choices
.claude/skills/in.gitignore(bare.claude->.claude/*+!.claude/skills/); personal.claudesettings stay ignored — verified.Verification
.claude/skills/.../SKILL.mdis tracked while.claude/settings.local.jsonremains ignored.Related
Complements #113 (which registers the Cortex/Databricks tool-calling features). This PR adds the tooling to keep the manifest honest going forward.