chore(ci): register Cortex and Databricks tool-calling features in manifest - #113
Merged
Merged
Conversation
…nifest Add carto-features.yml entries for the provider tool-calling fixes merged in PRs #109-#112 so they are protected by the CARTO Features Manifest Check against future upstream syncs: - Snowflake Cortex Claude function-calling follow-up turns (#111) - Snowflake Cortex array content flattening (#112) - Databricks empty tool_call arguments normalization (#109, #110) - Databricks strip OpenAI annotations (#110) All 19 verification patterns pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 4 missing entries to
.github/carto-features.ymlso the recently-merged provider tool-calling fixes are protected by the CARTO Features Manifest Check workflow against future upstream syncs.The manifest is a tripwire: each entry stores a
(pattern, file)fingerprint that CI greps for on everyupstream-sync/**push andcarto/mainPR. If a sync silently drops a CARTO customization, the missing pattern fails the check.These features (merged in #109–#112) had no manifest coverage:
def _content_to_text_blocks,def _strip_openai_annotations,text_prelude_blocksdef _content_to_text_stringdef _normalize_empty_tool_call_arguments,if fn.get("name") and not fn.get("arguments"):def _strip_openai_annotationsVerification
Ran the exact CI logic from
carto-features-check.ymllocally — 19/19 patterns verified (12 existing + 7 new), exit 0.Notes
source_prs/description/filesare documentation; onlyverificationdrives CI pass/fail.