Mapbox gl integration #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we talked off-line, we should upload those packages to our CDN (S3 bucket) and use it from there. I would also remove our fork of mapboxgl from |
why? |
|
We will use our CDN instead of unpkg. |
ok but in any case this is not important now |
|
Exactly, we can live with this. There are other critical issues to tackle first. |
Closed
Jesus89
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44
This PR uses our own fork from a CDN in the examples while
carto-vlsupport is not included in the mapboxgl repo.cc @rochoa @Jesus89 @davidmanzanares