Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using MGL fork #333

Closed
Jesus89 opened this issue Apr 24, 2018 · 3 comments
Closed

Using MGL fork #333

Jesus89 opened this issue Apr 24, 2018 · 3 comments
Assignees

Comments

@Jesus89
Copy link
Member

Jesus89 commented Apr 24, 2018

Now we are using the MGL forked bundle directly in this repo (vendor directory). It is a pain to update the bundle manually and also the @carto/mapbox-gl package. We can optimize this.

In carto-vl we use MGL in the tests (render, user, e2e) and the examples.

For the tests, we should use our MGL fork as a devDependency. For the examples, we should use our published MGL package (#270).

In our fork we should keep the master branch updated, so we need to create a carto branch with our PR merged and the package name updated. For our releases, I would use the original version + -N for our updates. Note: do not forget to generate the dist before doing a release.

@Jesus89 Jesus89 self-assigned this Apr 24, 2018
@IagoLast
Copy link
Contributor

+1

@Jesus89
Copy link
Member Author

Jesus89 commented Apr 25, 2018

We have decided to wait until the MGL v0.45.0 stable version to do the acceptance and merge of this PR.

@Jesus89
Copy link
Member Author

Jesus89 commented Apr 30, 2018

Closed by #339

@Jesus89 Jesus89 closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants