-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9. Emit 'open' event in createReadStream and createWriteStream. #10
Conversation
Thank you, I just pushed updated .travis.yml file, so it would be great if you could do a rebase please. |
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "fs-mock", | |||
"description": "Simple fs mock with posix and windows file system styles", | |||
"version": "1.1.2", | |||
"version": "1.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, can I ask you to revert that change? I'll do that later myself
I've made the requested changes. |
Just one last thing, can I ask you to squash all commits please? |
This fixes a bug where the 'open' event was not emitted from createReadStream and createWriteStream when they were opened.
Done |
Fix #9. Emit 'open' event in createReadStream and createWriteStream.
Thanks again |
Any ETA on when the new version might be published? |
At first I wanted to wait for response to #8, but I'll probably release new version right now. |
done |
Thanks |
This fixes a bug where the 'open' event was not emitted from createReadStream and createWriteStream when they were opened.