Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createReadStream/createWriteStream not emitting 'open' events? #9

Closed
eugirdor opened this issue Feb 3, 2015 · 4 comments
Closed

createReadStream/createWriteStream not emitting 'open' events? #9

eugirdor opened this issue Feb 3, 2015 · 4 comments
Labels
compatibility

Comments

@eugirdor
Copy link
Contributor

eugirdor commented Feb 3, 2015

As far as I can tell, the createReadStream and createWriteStream methods are not emitting 'open' events when they successfully open their respective streams.
@davidkudera
Copy link
Member

Oops.. Thanks, do you want to create PR?

@eugirdor
Copy link
Contributor Author

eugirdor commented Feb 3, 2015

Sure, I can probably create one in the next couple of days.

@davidkudera
Copy link
Member

That would be great, thank you :)

@eugirdor
Copy link
Contributor Author

eugirdor commented Feb 5, 2015

I issued a pull request, but it seems to fail on the build server for Node 0.9 complaining about the version of CoffeeScript. I didn't change the version it was using.

davidkudera added a commit that referenced this issue Feb 5, 2015
@davidkudera
Merge pull request #10 from eugirdor/emit-open-event
7f9e16d 
Fix #9. Emit 'open' event in createReadStream and createWriteStream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eugirdor @davidkudera