Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support customized run_name in tracker #573

Merged
merged 1 commit into from
Oct 26, 2023
Merged

support customized run_name in tracker #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions trlx/data/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ class TrainConfig:
trainer_kwargs: Dict[str, Any] = field(default_factory=dict) # Extra keyword arguments for the trainer

project_name: str = "trlx"
run_name: Optional[str] = None
entity_name: Optional[str] = None
group_name: Optional[str] = None

Expand Down
4 changes: 3 additions & 1 deletion trlx/trainer/accelerate_base_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ def __init__(self, config, **kwargs): # noqa: C901
num_gpus = f"{self.accelerator.num_processes}gpus"
branch = get_git_tag()[0]

run_name = "/".join([script_name, model_name, num_gpus]) + f":{branch}"
run_name = self.config.train.run_name
if not run_name:
run_name = "/".join([script_name, model_name, num_gpus]) + f":{branch}"

if self.accelerator.is_main_process:
config_dict = self.config.to_dict()
Expand Down
Loading