Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customized run_name in tracker #573

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Jingru
Copy link
Contributor

@Jingru Jingru commented Oct 24, 2023

Support customized run_name for tracker in train config

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcbcdac) 43.49% compared to head (5f3b44b) 43.52%.

❗ Current head 5f3b44b differs from pull request most recent head 4e668ca. Consider uploading reports for the commit 4e668ca to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   43.49%   43.52%   +0.03%     
==========================================
  Files          33       33              
  Lines        4971     4974       +3     
==========================================
+ Hits         2162     2165       +3     
  Misses       2809     2809              
Files Coverage Δ
trlx/data/configs.py 72.22% <100.00%> (+0.22%) ⬆️
trlx/trainer/accelerate_base_trainer.py 75.06% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@maxreciprocate maxreciprocate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxreciprocate maxreciprocate merged commit 0575ce5 into CarperAI:main Oct 26, 2023
2 checks passed
@Jingru Jingru deleted the support_customized_run_name branch November 7, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants