Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial GitHub workflows #43

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Oct 18, 2022

This PR adds initial GitHub workflows for building, testing, and checking for code quality.

@jon-tow
Copy link
Collaborator Author

jon-tow commented Oct 18, 2022

This relies on #42 for automatic flake8 dependency installation in the build.yml run.
Edit: Resolved with the latest merge.

@jon-tow jon-tow marked this pull request as draft October 18, 2022 20:11
@jon-tow jon-tow marked this pull request as ready for review October 18, 2022 20:34
@Dahoas
Copy link
Collaborator

Dahoas commented Oct 19, 2022

This looks good to me though I'm really not familiar with setting up github actions.

Do you mind removing the torch-typing errors with the fix you noted in discord?

@jon-tow
Copy link
Collaborator Author

jon-tow commented Oct 19, 2022

I've removed the "undefined name" check in the build workflow. CC @cat-state if they think we should add mypy in this PR or open a new one when we figure out how to properly set it up.

@Dahoas
Copy link
Collaborator

Dahoas commented Oct 19, 2022

If we think mypy can be set up by end of the week I'm for adding to this PR. If not we can merge now.

@LouisCastricato
Copy link
Contributor

Is this good to merge?

@cat-state
Copy link
Collaborator

I think let's do mypy on a subsequent one cus we'll have type errors and annotations to fix

@jon-tow
Copy link
Collaborator Author

jon-tow commented Oct 19, 2022

Le'ts merge. I'm currently unfamiliar with mypy and Aman might be too busy to add it right now. We can move discussions/concerns to issue #40.

@LouisCastricato LouisCastricato merged commit b2e523f into CarperAI:master Oct 19, 2022
@jon-tow jon-tow deleted the add-github-workflows branch October 20, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants