Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Improve package setup #42

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

jon-tow
Copy link
Collaborator

@jon-tow jon-tow commented Oct 18, 2022

This PR addresses package setup issues with the following updates:

  • Adds package finding to setup.cfg to avoid "multiple top-level packages" errors during new environment installs.
  • Updates README.md installation instructions to use pip install -e ..., as python setup.py ... is deprecated and should be replaced with pip tools (reference guide).
  • Adds separate dev dependencies to setup.cfg to avoid forcing dev dependencies on package install.
    • Adopts pytest as the test runner.
  • Renames unittests to tests to avoid confusion with unittest module and adhere to common Python unit-test directory naming.

@Dahoas
Copy link
Collaborator

Dahoas commented Oct 19, 2022

This is great thanks!

@jon-tow jon-tow deleted the improve-setup branch October 19, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants