Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: load function for AccelerateRLModel #136

Merged
merged 3 commits into from
Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 6 additions & 33 deletions trlx/model/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,41 +96,14 @@ def learn(
pass

@abstractmethod
def get_components(self) -> Dict[str, Any]:
"""
Get pytorch components (mainly for saving/loading)
"""
def save(self, directory=None):
"""Create checkpoint of model"""
pass

def save(self, fp: str, title: str = "OUT"):
"""
Try to save all components to specified path under a folder with given title
"""
path = os.path.join(fp, title)
safe_mkdir(path)

components = self.get_components()
for name in components:
try:
torch.save(components[name], os.path.join(path, name) + ".pt")
except:
print(f"Failed to save component: {name}, continuing.")

def load(self, fp: str, title: str = "OUT"):
"""
Try to load all components from specified path under a folder with given title
"""

path = os.path.join(fp, title)

components = self.get_components()
for name in components:
try:
components[name] = torch.load(
os.path.join(path, name) + ".pt", map_location="cpu"
)
except:
print(f"Failed to load component: {name}, continuing.")
@abstractmethod
def load(self, directory=None):
"""Load Checkpoints for model"""
pass

def intervals(self, steps: int) -> Dict[str, bool]:
"""
Expand Down
12 changes: 4 additions & 8 deletions trlx/model/accelerate_base_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,18 +128,14 @@ def generate(self, input_ids, attention_mask=None, **kwargs):
input_ids=input_ids, attention_mask=attention_mask, **kwargs
)

def get_components(self) -> Dict[str, Any]:
components = (
{"model": self.model, "opt": self.opt, "scheduler": self.scheduler}
if self.train_mode
else {"model": self.model}
)
return components

def save(self, directory=None):
"""Creates checkpoint of optimizer, scheduler and a model"""
self.accelerator.save_state(directory or self.config.train.checkpoint_dir)

def load(self, directory=None):
"""Load checkpoint of optimizer, scheduler and a model"""
self.accelerator.load_state(directory or self.config.train.checkpoint_dir)
dongs0104 marked this conversation as resolved.
Show resolved Hide resolved

def add_eval_pipeline(self, eval_pipeline):
"""Adds pipeline from with validation prompts"""
self.eval_pipeline = eval_pipeline
Expand Down