Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: load function for AccelerateRLModel #136

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

dongs0104
Copy link
Contributor

save and load are being done in different ways.

After performing the example, the model that was save at ckpts
it call

def save(self, directory=None):

when I use ckpts weight it call
def load(self, fp: str, title: str = "OUT"):

Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the fix! I've left a nit and change request.

trlx/model/accelerate_base_model.py Outdated Show resolved Hide resolved
trlx/model/accelerate_base_model.py Show resolved Hide resolved
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @dongs0104 !

@jon-tow jon-tow merged commit f411bf8 into CarperAI:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants