chore(doc): update supported data source#1409
Conversation
📝 WalkthroughWalkthroughREADME.md updated: corrected BigQuery link target and expanded the Supported Data Sources list with eight new entries (Minio, MySQL Server, Oracle Server, PostgreSQL Server, Athena, Databricks, Redshift, Apache Spark). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@README.md`:
- Line 46: Correct the typo "Apache Saprk" to "Apache Spark" in the README link
text (search for the literal "Apache Saprk" or the link line referencing
getwren.ai/oss/wren_engine_api#tag/SparkConnectionInfo) so the displayed text
reads "[Apache
Spark](https://docs.getwren.ai/oss/wren_engine_api#tag/SparkConnectionInfo)";
keep the URL unchanged and update only the visible link label.
- Around line 43-46: The README contains a typo in the link display text "Apache
Saprk" — update that string to "Apache Spark" in the README (replace the
incorrect "Apache Saprk" token so the list entry reads "Apache Spark" while
keeping the existing link unchanged).
🧹 Nitpick comments (1)
README.md (1)
31-46: Consider alphabetizing the data sources list for better discoverability.The supported data sources list is not in alphabetical order. Alphabetizing the list would improve user experience by making it easier for users to quickly locate specific data sources.
📋 Suggested alphabetical ordering
## 🔌 Supported Data Sources +- [Amazon S3](https://docs.getwren.ai/oss/wren_engine_api#tag/S3FileConnectionInfo) +- [Apache Spark](https://docs.getwren.ai/oss/wren_engine_api#tag/SparkConnectionInfo) +- [Athena](https://docs.getwren.ai/oss/wren_engine_api#tag/AthenaConnectionInfo) - [BigQuery](https://docs.getwren.ai/oss/wren_engine_api#tag/BigQueryProjectConnectionInfo) +- [Databricks](https://docs.getwren.ai/oss/wren_engine_api#tag/DatabricksTokenConnectionInfo) - [Google Cloud Storage](https://docs.getwren.ai/oss/wren_engine_api#tag/GcsFileConnectionInfo) - [Local Files](https://docs.getwren.ai/oss/wren_engine_api#tag/LocalFileConnectionInfo) +- [Minio](https://docs.getwren.ai/oss/wren_engine_api#tag/MinioFileConnectionInfo) - [MS SQL Server](https://docs.getwren.ai/oss/wren_engine_api#tag/MSSqlConnectionInfo) -- [Minio](https://docs.getwren.ai/oss/wren_engine_api#tag/MinioFileConnectionInfo) - [MySQL Server](https://docs.getwren.ai/oss/wren_engine_api#tag/MySqlConnectionInfo) - [Oracle Server](https://docs.getwren.ai/oss/wren_engine_api#tag/OracleConnectionInfo) - [PostgreSQL Server](https://docs.getwren.ai/oss/wren_engine_api#tag/PostgresConnectionInfo) -- [Amazon S3](https://docs.getwren.ai/oss/wren_engine_api#tag/S3FileConnectionInfo) +- [Redshift](https://docs.getwren.ai/oss/wren_engine_api#tag/RedshiftConnectionInfo) - [Snowflake](https://docs.getwren.ai/oss/wren_engine_api#tag/SnowflakeConnectionInfo) - [Trino](https://docs.getwren.ai/oss/wren_engine_api#tag/TrinoConnectionInfo) -- [Athena](https://docs.getwren.ai/oss/wren_engine_api#tag/AthenaConnectionInfo) -- [Databricks](https://docs.getwren.ai/oss/wren_engine_api#tag/DatabricksTokenConnectionInfo) -- [Redshift](https://docs.getwren.ai/oss/wren_engine_api#tag/RedshiftConnectionInfo) -- [Apache Saprk](https://docs.getwren.ai/oss/wren_engine_api#tag/SparkConnectionInfo)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.