Conversation
- Supported Data Sources with links
WalkthroughA new section titled "Supported Data Sources" has been added to the README.md file. This section appears directly after the Wren Engine overview image and provides a list of supported data sources, each with a link to its respective API documentation tag. No other changes or modifications to code or structure were made. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
31-31: Enhance context with an introductory sentence
Right after the## 🔌 Supported Data Sourcesheading, consider adding a brief description—such as “Wren Engine currently supports connecting to the following data sources:”—to give readers immediate context before they scan the list.
32-42: Optional: Sort or group the data sources
The list isn’t strictly alphabetical—consider ordering entries alphabetically or grouping by category (e.g., cloud warehouses, relational databases, file stores) to help users locate their connector more quickly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
README.md (1)
32-42:Details
✅ Verification successful
Verify documentation link health
Broken or outdated anchors can confuse users. Please run the following script to ensure each URL in this block returns HTTP 200:
🏁 Script executed:
#!/usr/bin/env bash set -euo pipefail urls=( "https://docs.getwren.ai/oss/wren_engine_api#tag/BigQueryConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/GcsFileConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/LocalFileConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/MSSqlConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/MinioFileConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/MySqlConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/OracleConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/PostgresConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/S3FileConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/SnowflakeConnectionInfo" "https://docs.getwren.ai/oss/wren_engine_api#tag/TrinoConnectionInfo" ) for url in "${urls[@]}"; do status=$(curl -s -o /dev/null -w "%{http_code}" "$url") if [[ "$status" -ne 200 ]]; then echo "⚠️ $url returned HTTP $status" fi doneLength of output: 2701
Documentation link health verified
All listed URLs inREADME.mdreturned HTTP 200—no broken or outdated anchors detected.
|
Thansk @chilijung |
Summary by CodeRabbit