Skip to content

chore(ibis): improve the date add/sub function for snowflake #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goldmedal merged 1 commit into from
Aug 15, 2025
Merged

chore(ibis): improve the date add/sub function for snowflake #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ibis-server/resources/function_list/snowflake.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ scalar,base64_encode,string,"Encodes binary to base64"
scalar,base64_decode,binary,"Decodes base64 to binary"
scalar,char,string,"Returns character from ASCII code"
scalar,charindex,numeric,"Returns position of substring"
scalar,date_add,timestamp,"Adds interval to date"
scalar,date_sub,timestamp,"Subtracts interval from date"
scalar,dateadd,timestamp,"Adds the specified value for the specified date or time part to a date, time, or timestamp."
scalar,datediff,integer,"Calculates the difference between two date, time, or timestamp expressions based on the date or time part requested. The function returns the result of subtracting the second argument from the third argument."
scalar,dayname,string,"Returns name of day"
scalar,dayofmonth,numeric,"Returns day of month (1-31)"
scalar,dayofweek,numeric,"Returns day of week (0-6)"
Expand Down Expand Up @@ -47,6 +47,9 @@ scalar,split,array,"Splits string into array"
scalar,startswith,boolean,"Tests if string starts with prefix"
scalar,time_slice,timestamp,"Truncates timestamp to interval"
scalar,timeadd,timestamp,"Adds interval to timestamp"
scalar,timediff,interval,"Calculates difference between two timestamps"
scalar,timestampadd,timestamp,"Adds interval to timestamp"
scalar,timestampdiff,interval,"Calculates difference between two timestamps"
scalar,to_array,array,"Converts value to array"
scalar,to_json,string,"Converts to JSON string"
scalar,to_number,numeric,"Converts to number"
Expand Down
2 changes: 1 addition & 1 deletion ibis-server/tests/routers/v3/connector/snowflake/test_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ async def test_function_list(client):
response = await client.get(url=f"{base_url}/functions")
assert response.status_code == 200
result = response.json()
# assert len(result) == DATAFUSION_FUNCTION_COUNT + 60
assert len(result) == DATAFUSION_FUNCTION_COUNT + 63
the_func = next(filter(lambda x: x["name"] == "is_null_value", result))
assert the_func == {
"name": "is_null_value",
Expand Down