Skip to content

chore(ibis): improve the date add/sub function for snowflake#1286

Merged
goldmedal merged 1 commit intoCanner:mainfrom
goldmedal:chore/add-date-function-snowflake
Aug 15, 2025
Merged

chore(ibis): improve the date add/sub function for snowflake#1286
goldmedal merged 1 commit intoCanner:mainfrom
goldmedal:chore/add-date-function-snowflake

Conversation

@goldmedal
Copy link
Copy Markdown
Contributor

@goldmedal goldmedal commented Aug 15, 2025

Add the datetime addition/subtraction functions to the function list of snowfalke

  • dateadd
  • datediff
  • timediff
  • timestampadd
  • timestampdiff

Summary by CodeRabbit

  • New Features

    • Snowflake connector now exposes three additional functions in the function catalog, expanding available operations visible in the /functions endpoint and for query building.
  • Tests

    • Updated expectations to reflect the increased function count when using the remote function list configuration for Snowflake, ensuring test coverage aligns with the expanded catalog.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 15, 2025

Walkthrough

Adjusts a Snowflake connector v3 test to expect three additional functions in the /functions API response when a remote function list is configured; no other logic changes.

Changes

Cohort / File(s) Summary of changes
Tests – Snowflake Connector v3
ibis-server/tests/routers/v3/connector/snowflake/test_functions.py
Updated expected count in test_function_list from DATAFUSION_FUNCTION_COUNT + 60 to + 63; no other assertions or logic modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ibis, python

Suggested reviewers

  • douenergy

Poem

I twitch my nose at functions three,
New snowflakes drifting silently.
Count them once, then count them thrice—
Tests now match the frosty slice.
In winter’s code, I hop with glee,
For every plus adds harmony. 🐇❄️

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ibis python Pull requests that update Python code labels Aug 15, 2025
@goldmedal goldmedal requested a review from douenergy August 15, 2025 06:21
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 82174fa and a1a0b03.

⛔ Files ignored due to path filters (1)
  • ibis-server/resources/function_list/snowflake.csv is excluded by !**/*.csv
📒 Files selected for processing (1)
  • ibis-server/tests/routers/v3/connector/snowflake/test_functions.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ci

@goldmedal goldmedal merged commit f23d1bd into Canner:main Aug 15, 2025
5 checks passed
@goldmedal goldmedal deleted the chore/add-date-function-snowflake branch August 15, 2025 07:32
nhaluc1005 pushed a commit to nhaluc1005/text2sql-practice that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibis python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants