Skip to content

feat(snowflake): add optional warehouse support to connection #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douenergy merged 2 commits into from
Aug 5, 2025
Merged

feat(snowflake): add optional warehouse support to connection #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
558c2c1
make warehouse optional
douenergy Aug 5, 2025
f993659
Update ibis-server/app/model/data_source.py
douenergy Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 29 additions & 17 deletions ibis-server/app/model/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,25 +348,37 @@ def get_oracle_connection(info: OracleConnectionInfo) -> BaseBackend:

@staticmethod
def get_snowflake_connection(info: SnowflakeConnectionInfo) -> BaseBackend:
# private key authentication
if hasattr(info, "private_key") and info.private_key:
return ibis.snowflake.connect(
user=info.user.get_secret_value(),
account=info.account.get_secret_value(),
database=info.database.get_secret_value(),
schema=info.sf_schema.get_secret_value(),
warehouse=info.warehouse.get_secret_value(),
private_key=info.private_key.get_secret_value(),
**info.kwargs if info.kwargs else dict(),
)
connection_params = {
"user": info.user.get_secret_value(),
"private_key": info.private_key.get_secret_value(),
"account": info.account.get_secret_value(),
"database": info.database.get_secret_value(),
"schema": info.sf_schema.get_secret_value(),
}
# warehouse if it exists and is not None/empty
if hasattr(info, "warehouse") and info.warehouse:
connection_params["warehouse"] = info.warehouse.get_secret_value()
if info.kwargs:
connection_params.update(info.kwargs)
return ibis.snowflake.connect(**connection_params)
else:
return ibis.snowflake.connect(
user=info.user.get_secret_value(),
password=info.password.get_secret_value(),
account=info.account.get_secret_value(),
database=info.database.get_secret_value(),
schema=info.sf_schema.get_secret_value(),
**info.kwargs if info.kwargs else dict(),
)
# password authentication
connection_params = {
"user": info.user.get_secret_value(),
"password": info.password.get_secret_value(),
"account": info.account.get_secret_value(),
"database": info.database.get_secret_value(),
"schema": info.sf_schema.get_secret_value(),
}

# warehouse if it exists and is not None/empty
if hasattr(info, "warehouse") and info.warehouse:
connection_params["warehouse"] = info.warehouse.get_secret_value()
if info.kwargs:
connection_params.update(info.kwargs)
return ibis.snowflake.connect(**connection_params)

@staticmethod
def get_trino_connection(info: TrinoConnectionInfo) -> BaseBackend:
Expand Down
51 changes: 48 additions & 3 deletions ibis-server/tests/routers/v2/connector/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
"private_key": os.getenv("SNOWFLAKE_PRIVATE_KEY"),
}

connection_info_without_warehouse = {
"user": os.getenv("SNOWFLAKE_USER"),
"account": os.getenv("SNOWFLAKE_ACCOUNT"),
"database": "SNOWFLAKE_SAMPLE_DATA",
"schema": "TPCH_SF1",
"private_key": os.getenv("SNOWFLAKE_PRIVATE_KEY"),
}

password_connection_info = {
"user": os.getenv("SNOWFLAKE_USER"),
"password": os.getenv("SNOWFLAKE_PASSWORD"),
Expand Down Expand Up @@ -109,7 +117,44 @@ async def test_query(client, manifest_str):
"orderkey": "int64",
"custkey": "int64",
"orderstatus": "string",
"totalprice": "decimal128(12, 2)",
"totalprice": "decimal128(38, 9)",
"orderdate": "date32[day]",
"order_cust_key": "string",
"timestamp": "timestamp[ns]",
"timestamptz": "timestamp[ns, tz=UTC]",
"test_null_time": "timestamp[ns]",
}


async def test_query_without_warehouse(client, manifest_str):
response = await client.post(
url=f"{base_url}/query",
json={
"connectionInfo": connection_info_without_warehouse,
"manifestStr": manifest_str,
"sql": 'SELECT * FROM "Orders" ORDER BY "orderkey" LIMIT 1',
},
)
assert response.status_code == 200
result = response.json()
assert len(result["columns"]) == len(manifest["models"][0]["columns"])
assert len(result["data"]) == 1
assert result["data"][0] == [
1,
36901,
"O",
"173665.47",
"1996-01-02",
"1_36901",
"2024-01-01 23:59:59.000000",
"2024-01-01 23:59:59.000000 +00:00",
None,
]
assert result["dtypes"] == {
"orderkey": "int64",
"custkey": "int64",
"orderstatus": "string",
"totalprice": "decimal128(38, 9)",
"orderdate": "date32[day]",
"order_cust_key": "string",
"timestamp": "timestamp[ns]",
Expand Down Expand Up @@ -139,14 +184,14 @@ async def test_query_with_password_connection_info(client, manifest_str):
"1996-01-02",
"1_36901",
"2024-01-01 23:59:59.000000",
"2024-01-01 23:59:59.000000 UTC",
"2024-01-01 23:59:59.000000 +00:00",
None,
]
assert result["dtypes"] == {
"orderkey": "int64",
"custkey": "int64",
"orderstatus": "string",
"totalprice": "decimal128(12, 2)",
"totalprice": "decimal128(38, 9)",
"orderdate": "date32[day]",
"order_cust_key": "string",
"timestamp": "timestamp[ns]",
Expand Down