feat(snowflake): add optional warehouse support to connection

[douenergy]

We should not restrict users from specifying the warehouse they use. If the warehouse is None, Snowflake will use the default warehouse automatically.

Summary by CodeRabbit

• Tests
  • Added a new test to verify Snowflake queries without specifying a warehouse.
  • Expanded test coverage for additional columns and updated expected data types.
  • Adjusted decimal precision and timestamp formats in existing test assertions.

[coderabbitai]

Walkthrough

The get_snowflake_connection method was refactored to incrementally build the connection parameters dictionary, conditionally including the warehouse key and merging additional keyword arguments before connecting. Tests were updated to cover cases without the warehouse parameter, expand expected data types, and adjust decimal precision and timestamp formats in assertions.

Changes

Cohort / File(s)	Change Summary
Snowflake Connection Refactor ibis-server/app/model/data_source.py	Refactored get_snowflake_connection to incrementally construct the connection parameters dictionary, conditionally add the warehouse key, and merge additional kwargs before connecting. Authentication and control flow remain unchanged.
Snowflake Connector Test Enhancements ibis-server/tests/routers/v2/connector/test_snowflake.py	Added connection_info_without_warehouse config and a new async test for connections without warehouse. Expanded expected data types, adjusted decimal precision, and updated timestamp formats in assertions for existing tests.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant DataSource
    participant IbisSnowflake

    Caller->>DataSource: get_snowflake_connection(info)
    DataSource->>DataSource: Build connection_params dict
    alt private_key auth
        DataSource->>DataSource: Add private_key to params
    else password auth
        DataSource->>DataSource: Add password to params
    end
    DataSource->>DataSource: Conditionally add warehouse
    DataSource->>DataSource: Merge info.kwargs
    DataSource->>IbisSnowflake: connect(**connection_params)
    IbisSnowflake-->>DataSource: Connection object
    DataSource-->>Caller: Return connection

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(ibis): Snowflake key-pair authentication support  #1230: Refactored get_snowflake_connection for key-pair authentication and handling warehouse and private_key parameters.
• fix(ibis): Restore support for Snowflake password authentication #1236: Modified the same method to support both private key and password authentication, closely related to connection parameter handling.

Suggested reviewers

• goldmedal

Poem

A rabbit hopped through Snowflake’s door,
Tweaked connections, checked types galore.
Warehouse key? Now it’s optional,
Decimal points—more precise, not marginal!
Tests leap higher, precision in sight,
Hopping forward, code feels light.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 558c2c1 and f993659.

📒 Files selected for processing (1)

• ibis-server/app/model/data_source.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ibis-server/app/model/data_source.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ci

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[goldmedal]

Thanks @douenergy. I have only one suggestion for the get_snowflake_connection