-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wren-ui/e2e): Update E2E test for navigation change #924
Conversation
Hi @fredalai, could you review my PR when you have a chance? Thanks! |
Hi @ongdisheng, Thank you for your contribution. 😄 Would you like to fix the connectSampleECommerce.spec.ts and connectSampleHR.spec.ts for the navigation change issue? |
Sure, no problem 😄. |
Hi @fredalai, I’ve updated Thanks a lot. |
Hi @ongdisheng, Thanks~ LGTM 😄 |
7a747b2
to
f6e53a3
Compare
Hi @fredalai, I’ve also updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :D
Description
This issue was identified as a navigation change introduced in PR #843, which redirects to the Modeling page after onboarding. Fix #922.
Screenshots
PostgreSQL
Trino