Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wren-ui/e2e): Update E2E test for navigation change #924

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ongdisheng
Copy link
Contributor

@ongdisheng ongdisheng commented Nov 18, 2024

Description

This issue was identified as a navigation change introduced in PR #843, which redirects to the Modeling page after onboarding. Fix #922.

Screenshots

  • PostgreSQL
    Screenshot 2024-11-19 at 7 29 39 AM

  • Trino
    Screenshot 2024-11-19 at 7 44 38 AM

@ongdisheng ongdisheng marked this pull request as ready for review November 18, 2024 23:47
@ongdisheng
Copy link
Contributor Author

Hi @fredalai, could you review my PR when you have a chance? Thanks!

@fredalai
Copy link
Contributor

Hi @ongdisheng,

Thank you for your contribution. 😄

Would you like to fix the connectSampleECommerce.spec.ts and connectSampleHR.spec.ts for the navigation change issue?
Also, no worry, I know PR #855 breaks the E2E tests for the Sample dataset, just ignore this PR and we'll fix subsequent tests in a new PR.

@ongdisheng
Copy link
Contributor Author

Sure, no problem 😄.

@ongdisheng
Copy link
Contributor Author

Hi @ongdisheng,

Thank you for your contribution. 😄

Would you like to fix the connectSampleECommerce.spec.ts and connectSampleHR.spec.ts for the navigation change issue? Also, no worry, I know PR #855 breaks the E2E tests for the Sample dataset, just ignore this PR and we'll fix subsequent tests in a new PR.

Hi @fredalai, I’ve updated connectSampleHR.spec.ts. Could you take a look if it’s okay when you’re free before I proceed with connectSampleECommerce.spec.ts.

Thanks a lot.

@fredalai
Copy link
Contributor

Hi @ongdisheng,
Thank you for your contribution. 😄
Would you like to fix the connectSampleECommerce.spec.ts and connectSampleHR.spec.ts for the navigation change issue? Also, no worry, I know PR #855 breaks the E2E tests for the Sample dataset, just ignore this PR and we'll fix subsequent tests in a new PR.

Hi @fredalai, I’ve updated connectSampleHR.spec.ts. Could you take a look if it’s okay when you’re free before I proceed with connectSampleECommerce.spec.ts.

Thanks a lot.

Hi @ongdisheng,

Thanks~ LGTM 😄

@ongdisheng ongdisheng changed the title fix(wren-ui/e2e): Update data source E2E test for navigation change fix(wren-ui/e2e): Update E2E test for navigation change Nov 19, 2024
@ongdisheng
Copy link
Contributor Author

Hi @fredalai, I’ve also updated connectSampleECommerce.spec.ts. Let me know if further changes are needed.
Thanks!

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :D

@fredalai fredalai merged commit 0abc506 into Canner:main Nov 19, 2024
3 checks passed
@ongdisheng ongdisheng deleted the issue-922 branch November 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source E2E Test Failure
2 participants