Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wren-ui): Implement modeling page onboarding guide #843

Merged
merged 12 commits into from
Oct 30, 2024
Merged

feat(wren-ui): Implement modeling page onboarding guide #843

merged 12 commits into from
Oct 30, 2024

Conversation

andreashimin
Copy link
Contributor

Description

This PR aims to provide users quick learning on the modeling page after onboarding.

  • After onboarding, navigate to the modeling page
  • Auto-trigger data modeling guide for users
  • If users close the first guide without finishing, the data modeling guide will be triggered if users open a new window.
  • The learning section will be minimized if users finish their learning.

Recording

Screen.Recording.2024-10-29.at.9.12.42.PM.mov

@andreashimin andreashimin added the module/ui UI related label Oct 29, 2024
onlyjackfrost
onlyjackfrost approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one comment, others LGTM for the BE part

wren-ui/src/apollo/server/resolvers/learningResolver.ts Outdated Show resolved Hide resolved
fredalai
fredalai approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one comment, we also need to update router. push to Path.Modeling for the startSampleDatasetMutation.
https://github.com/Canner/WrenAI/blob/feature/onboarding-guide/wren-ui/src/hooks/useSetupConnection.tsx#L95

@andreashimin andreashimin merged commit d63af5f into main Oct 30, 2024
7 checks passed
@andreashimin andreashimin deleted the feature/onboarding-guide branch October 30, 2024 04:05
@ongdisheng ongdisheng mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredalai fredalai fredalai approved these changes

@onlyjackfrost onlyjackfrost onlyjackfrost approved these changes

@wwwy3y3 wwwy3y3 Awaiting requested review from wwwy3y3

Assignees
No one assigned
Labels
module/ui UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreashimin @onlyjackfrost @fredalai