[WNMGDS-3186] Pulls in an accessibility fix for react-aria's <HiddenSelect />#3452
Merged
4 commits merged intoFeb 19, 2025
Merged
[WNMGDS-3186] Pulls in an accessibility fix for react-aria's <HiddenSelect />#34524 commits merged into
react-aria's <HiddenSelect />#34524 commits merged into
Conversation
added 2 commits
February 18, 2025 17:16
ghost
added
Type: Fixed
Collaborator
V nice 👌🏻 |
jack-ryan-nava-pbc
approved these changes
Feb 19, 2025
Collaborator
jack-ryan-nava-pbc
left a comment
jack-ryan-nava-pbc
left a comment
There was a problem hiding this comment.
Looks good and passes tests!
ghost
merged commit
tamara-corbalt
pushed a commit
that referenced
this pull request
Apr 1, 2025
…enSelect />` (#3452) * applies changes from adobe/react-spectrum#7200 to local `react-aria` copy * Updates snapshots * Updates WC snapshots
jack-ryan-nava-pbc
pushed a commit
that referenced
this pull request
Apr 10, 2025
…enSelect />` (#3452) * applies changes from adobe/react-spectrum#7200 to local `react-aria` copy * Updates snapshots * Updates WC snapshots
jack-ryan-nava-pbc
pushed a commit
that referenced
this pull request
Apr 10, 2025
…enSelect />` (#3452) * applies changes from adobe/react-spectrum#7200 to local `react-aria` copy * Updates snapshots * Updates WC snapshots
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira ticket
When initially loading the
Dropdowncomponent in Storybook (link), thetabIndexfor the hiddeninputfield was set to -1, which is great — no accessibility issues at that point. However, after interacting with the page (either via keyboard or mouse events) thereact-arialibrary would set thetabIndexto 0, which does register as an accessibility issue.This PR pulls in the specific changed lines found in this PR (adobe/react-spectrum#7200) to the local copy of
react-ariathat affects theHiddenSelectcomponent / function. Note: this does not update the package.json version dependency ofreact-ariaor the rest of the local library. I'm thinking that will require a more meticulous approach and should be prioritized appropriately. Instead, this follows precedence set forth with this commit (01e01e2).How to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)