Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WNMGDS-2714] Fix Dialog and HelpDrawer analytics firing too early #3055

Merged
merged 9 commits into from
Apr 25, 2024
Merged

[WNMGDS-2714] Fix Dialog and HelpDrawer analytics firing too early #3055

merged 9 commits into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. Fix Dialog firing open and close events at wrong time

    @pwolfert
    pwolfert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b59fb3b View commit details
    Browse the repository at this point in the history

  2. Separate that logic into a hook so it can be shared

    @pwolfert
    pwolfert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    30b57d8 View commit details
    Browse the repository at this point in the history

  3. Apply the fix to HelpDrawer too

    @pwolfert
    pwolfert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ee28bd0 View commit details
    Browse the repository at this point in the history

  4. Update snapshots again after rebasing

    @pwolfert
    pwolfert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    baef996 View commit details
    Browse the repository at this point in the history

  5. Fix analytics in help drawer story

    @pwolfert
    pwolfert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1ced7b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Fix copypasta in test names

    @pwolfert
    pwolfert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9a489c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pwolfert/dialog-analytics-fix

    @pwolfert
    pwolfert authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8544c0b View commit details
    Browse the repository at this point in the history

  3. Oh, snapshots have to be updated when the names change

    @pwolfert
    pwolfert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    429da6e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pwolfert/dialog-analytics-fix' of https://github.com/CM… 

    …Sgov/design-system into pwolfert/dialog-analytics-fix
    @pwolfert
    pwolfert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6949330 View commit details
    Browse the repository at this point in the history