[WNMGDS-2714] Fix Dialog and HelpDrawer analytics firing too early
#3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwolfert
added
Type: Fixed
zarahzachz
reviewed
Apr 25, 2024
| @@ -52,9 +62,31 @@ describe('HelpDrawer', () => { | |||
| jest.resetAllMocks(); | |||
| }); | |||
|
|
|||
| it('sends analytics event tracking on open help drawer', () => { | |||
| renderHelpDrawer(); | |||
| it("does not send analytics event when dialog isn't open", () => { | |||
There was a problem hiding this comment.
Does calling the tests "dialog" matter if it's underlying element is <dialog> 🤔
pwolfert
added a commit
that referenced
this pull request
Apr 25, 2024
I can find no evidence of people using it, and it has the same defect as #3055
4 tasks
zarahzachz
approved these changes
Apr 25, 2024
pwolfert
added a commit
that referenced
this pull request
May 10, 2024
#3055) * Fix `Dialog` firing open and close events at wrong time * Separate that logic into a hook so it can be shared * Apply the fix to `HelpDrawer` too * Update snapshots again after rebasing * Fix analytics in help drawer story * Fix copypasta in test names * Oh, snapshots have to be updated when the names change
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
DialogandHelpDraweranalytics open event firing before it's actually opened. When we changed theNativeDialogAPI to use anisOpenprop to control its open state, it meant that rendering aNativeDialogwas no longer equivalent to opening a dialog. Our analytics events forDialogandHelpDraweropen and close were based on mounting and unmounting the components, so when one of those comonents rendered, it would fire the open event even ifisOpenwasfalse.How to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)