Skip to content

Conversation

@TheodorNEngoy
Copy link
Contributor

Add OSS-Fuzz CIFuzz workflow to run fuzzers on PRs for project 'cli11'.

@phlptp
Copy link
Collaborator

phlptp commented Oct 14, 2025

@TheodorNEngoy I am excited to help with this, though I would like it to use the Fuzzer code that is built into CLI11 already rather than a new file.

@TheodorNEngoy
Copy link
Contributor Author

Please approve Actions so CIFuzz runs. Also, for OSS‑Fuzz we need a committer’s Google‑account email to use as primary_contact on google/oss-fuzz#14131 (tracking issue: #1224). Thanks!

@TheodorNEngoy
Copy link
Contributor Author

Thanks @phlptp — I set you as primary_contact in the OSS‑Fuzz PR (google/oss-fuzz#14131).

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e4ee3af) to head (5be19f8).
⚠️ Report is 133 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1225     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        19      +2     
  Lines         4546      5290    +744     
  Branches         0      1069   +1069     
===========================================
+ Hits          4546      5290    +744     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phlptp
Copy link
Collaborator

phlptp commented Oct 14, 2025

I presume this isn't supposed to work yet?

@TheodorNEngoy
Copy link
Contributor Author

CIFuzz uses the OSS‑Fuzz project config for 'cli11', so it will stay red until google/oss-fuzz#14131 is merged. All other checks are green.

@TheodorNEngoy
Copy link
Contributor Author

CIFuzz is set to soft-fail temporarily per OSS‑Fuzz CI requirements (project must exist in OSS‑Fuzz). We’ll revert once google/oss-fuzz#14131 is merged.

@phlptp
Copy link
Collaborator

phlptp commented Oct 15, 2025

So I am clear on this. This action will execute the configuration found in oss-fuzz related to cli11. It will run the fuzzer for 600 seconds. Is that 600 for each type of fuzzer or total? Is there anything special about 600? I understand wanting to test the workflow for OSS-fuzz with each PR in CLI11, but is there much to be gained from running for 10 minutes vs 5 minutes for example?

@TheodorNEngoy
Copy link
Contributor Author

@phlptp — quick answers on CIFuzz:

• Yes: the job builds and runs the fuzz targets using the OSS‑Fuzz project config for cli11.
fuzz-seconds is the total time budget for the “Run Fuzzers” step (default 600s). With OSS‑Fuzz coverage enabled, CIFuzz runs only fuzzers affected by the PR; otherwise it divides that time among all fuzz targets.
• 600s isn’t special beyond being the documented default/minimum. Maintainers should choose the longest acceptable time for the repo. If we later use a sanitizer matrix, each matrix job gets its own budget (e.g., ASan 600s, UBSan 600s).

Docs: https://google.github.io/oss-fuzz/getting-started/continuous-integration/

@TheodorNEngoy
Copy link
Contributor Author

Switched CIFuzz to dry-run temporarily because the OSS-Fuzz project for 'cli11' isn’t merged yet. This keeps CI green while still running fuzzers. We’ll remove dry-run after google/oss-fuzz#14131 lands.

@phlptp
Copy link
Collaborator

phlptp commented Oct 18, 2025

@TheodorNEngoy lets get the requested change in then I think this can be merged unless you want further changes.

@TheodorNEngoy
Copy link
Contributor Author

All checks are green here. The requested change on the OSS‑Fuzz side is in (only packaging fuzz_dictionary1). CIFuzz is temporarily dry‑run per docs, and we’ll flip it off after google/oss-fuzz#14131 merges. From my side this is ready — please approve the pending workflow and merge when convenient.

@phlptp
Copy link
Collaborator

phlptp commented Oct 18, 2025

The use of "true" in the workflow needs to be changed to "on" otherwise I think this will run on every commit, which I don't think we want. once that change is made I will merge this.

@TheodorNEngoy
Copy link
Contributor Author

Updated: use a proper on: block with pull_request (+ workflow_dispatch) so CIFuzz doesn’t run on every push. Still dry-run: true until google/oss-fuzz#14131 lands. Ready from my side.

Copy link
Collaborator

@phlptp phlptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the work flow file now , pull request shows up twice

@TheodorNEngoy
Copy link
Contributor Author

pre-commit.ci autofix

@TheodorNEngoy
Copy link
Contributor Author

pre-commit.ci run

@TheodorNEngoy
Copy link
Contributor Author

pre-commit.ci run

@TheodorNEngoy
Copy link
Contributor Author

Fixed the YAML (removed duplicate pull_request item, proper on: block). CIFuzz remains dry-run: true in Build+Run per OSS‑Fuzz docs. Ready to merge once checks pass.

@phlptp
Copy link
Collaborator

phlptp commented Oct 18, 2025

@all-contributors please add @TheodorNEngoy for infrastructure

@allcontributors
Copy link
Contributor

@phlptp

I've put up a pull request to add @TheodorNEngoy! 🎉

@phlptp phlptp merged commit 0c4cd5f into CLIUtils:main Oct 18, 2025
63 checks passed
phlptp pushed a commit that referenced this pull request Oct 18, 2025
Adds @TheodorNEngoy as a contributor for infra.

This was requested by phlptp [in this
comment](#1225 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants