-
Couldn't load subscription status.
- Fork 396
ci: add CIFuzz #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add CIFuzz #1225
Conversation
|
@TheodorNEngoy I am excited to help with this, though I would like it to use the Fuzzer code that is built into CLI11 already rather than a new file. |
|
Please approve Actions so CIFuzz runs. Also, for OSS‑Fuzz we need a committer’s Google‑account email to use as |
|
Thanks @phlptp — I set you as |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5290 +744
Branches 0 1069 +1069
===========================================
+ Hits 4546 5290 +744 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I presume this isn't supposed to work yet? |
|
CIFuzz uses the OSS‑Fuzz project config for 'cli11', so it will stay red until google/oss-fuzz#14131 is merged. All other checks are green. |
|
CIFuzz is set to soft-fail temporarily per OSS‑Fuzz CI requirements (project must exist in OSS‑Fuzz). We’ll revert once google/oss-fuzz#14131 is merged. |
|
So I am clear on this. This action will execute the configuration found in oss-fuzz related to cli11. It will run the fuzzer for 600 seconds. Is that 600 for each type of fuzzer or total? Is there anything special about 600? I understand wanting to test the workflow for OSS-fuzz with each PR in CLI11, but is there much to be gained from running for 10 minutes vs 5 minutes for example? |
|
@phlptp — quick answers on CIFuzz: • Yes: the job builds and runs the fuzz targets using the OSS‑Fuzz project config for Docs: https://google.github.io/oss-fuzz/getting-started/continuous-integration/ |
|
Switched CIFuzz to dry-run temporarily because the OSS-Fuzz project for 'cli11' isn’t merged yet. This keeps CI green while still running fuzzers. We’ll remove dry-run after google/oss-fuzz#14131 lands. |
|
@TheodorNEngoy lets get the requested change in then I think this can be merged unless you want further changes. |
|
All checks are green here. The requested change on the OSS‑Fuzz side is in (only packaging fuzz_dictionary1). CIFuzz is temporarily dry‑run per docs, and we’ll flip it off after google/oss-fuzz#14131 merges. From my side this is ready — please approve the pending workflow and merge when convenient. |
|
The use of "true" in the workflow needs to be changed to "on" otherwise I think this will run on every commit, which I don't think we want. once that change is made I will merge this. |
…il OSS-Fuzz project lands
|
Updated: use a proper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix the work flow file now , pull request shows up twice
|
pre-commit.ci autofix |
|
pre-commit.ci run |
|
pre-commit.ci run |
|
Fixed the YAML (removed duplicate |
|
@all-contributors please add @TheodorNEngoy for infrastructure |
|
I've put up a pull request to add @TheodorNEngoy! 🎉 |
Adds @TheodorNEngoy as a contributor for infra. This was requested by phlptp [in this comment](#1225 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Add OSS-Fuzz CIFuzz workflow to run fuzzers on PRs for project 'cli11'.