mods for running in NOAA#320
Conversation
|
I believe this is redundant with #319? Should it be closed? |
|
My re-fork from CICE master didn't have the theia/phase2/phase3/high_Sierra
files, so this seems like a good chance to test whether reforking has
indeed resolved all problems on my end.
Also, submitting request from my develop branch, as recommended.
…On Fri, May 31, 2019 at 11:29 AM Tony Craig ***@***.***> wrote:
I believe this is redundant with #319
<#319>? Should it be closed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#320?email_source=notifications&email_token=AFQ65HPOWD6GBBG6ZTESCUDPYE77FA5CNFSM4HR3U67KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVRS7Y#issuecomment-497752447>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFQ65HM5J5LJEH3WYH6NH4LPYE77FANCNFSM4HR3U67A>
.
--
Tel: 301-683-3747
Coupling and Dynamics Group
|
|
OK, sounds good. travis is passing for this, so I think your new fork is good. The diffs also look fine. @rgrumbine , could you close this PR. You can/should also update your fork master as follows git clone https://github.com/rgrumbine/cice cice.master Now your fork master will be synced with cice-consortium again. I do this everytime I checkout a new sandbox before creating a new branch and doing development. It's been helpful to me to keep my fork master clean and synced to the consortium master, and that's what's recommended in the consortium workflow. But if you have other ways you prefer to work, that's OK too. |
|
Will do. At the time I started, the consortium master had no changes relative to mine, so I didn't re-execute the pull upstream master. But yes, I have been and will continue the synchronization of my master with the consortium's. |
additions for running in NOAA
Developer(s):
Robert Grumbine
Please suggest code Pull Request reviewers in the column at right.
Are the code changes bit for bit, different at roundoff level, or more substantial?
Bit for bit
Please include the link to test results or paste the summary block from the bottom of the testing output below.
Does this PR create or have dependencies on Icepack or any other models?
No
Is the documentation being updated with this PR? (Y/N)
If not, does the documentation need to be updated separately at a later time? (Y/N)
no, no
Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.
clean launch, batch, env, and Macro file modifications / additions from newly re-forked CICE master