Add noaa machines and minor cleanup from RG#319
Merged
Conversation
Contributor
Author
|
I am running a quick test on conrad as well. I will report those results when I have them. But wanted to give @rgrumbine a chance to review this PR and for travis to do it's thing concurrently. |
Contributor
Author
|
I am going to close #317 at this point. |
Contributor
|
Thanks Tony. |
eclare108213
approved these changes
May 31, 2019
rgrumbine
approved these changes
May 31, 2019
Contributor
rgrumbine
left a comment
There was a problem hiding this comment.
thank you Tony. All looks good, and I've re-forked my copy of CICE.
Contributor
Author
|
Just to add, full test suite on conrad showed no problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NOAA machines and some cleanup, from @rgrumbine, see #317
Additions to run regression tests on NWS operational system 'phase2' and NOAA R+D system 'theia':
Developer(s): rgrumbine, tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Does this PR create or have dependencies on Icepack or any other models? N
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately at a later time? (Y/N) N
Other Relevant Details:
Though present, the theia_gnu and theia_pgi configurations have not been confirmed to pass the full regression suite.
This was a redo of PR #317 which caused problems due to some issues with the Icepack submodule setup. This is exactly f9ae148 from @rgrumbine's fork with the icepack submodule changes not brought over and the gitignore mod not included. It also includes few other mods to get rid of tabs in a few files that were noticed the sandbox was reviewed before committing.