-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening folders with shellexecute-on-windows
feature doesn't respect to 'expand to open folder' setting
#103
Comments
Thanks for posting! It's hard for me to understand why it would be annoying for lack of experience, but even without that it's clear that the new implementation has a side-effect and that could easily be considered unwanted. Hence, I would be glad if you could come up with a fix and would appreciate screenshots of the before/after state of the explorer window for visualisation (and to satisfy my curiosity :)). Thank you. |
shellexecute-on-windows
feature expands left panel to that folder's locationshellexecute-on-windows
feature doesn't respect to 'expand to open folder' setting
To respect 'expand to open folder setting ' Fixes Byron#103
To respect 'expand to open folder setting' Fixes Byron#103
fix(windows): use `SHOpenFolderAndSelectItems` for folders to respect expand to open folder setting fixes #103
A small thing, after #98, when opening folders with the current implementation, the left panel of the file explorer will expand the folder to the current location, and I find it being quite annoying, the old implementation using
open
as operation (it'sexplorer
now) doesn't have this problemI found that using
SHOpenFolderAndSelectItems
like thisSHOpenFolderAndSelectItems(folder, Some(&[folder]), 0)
will open that folder without expanding the left panel, and I don't think this will cause the explorer to freeze, do you think we can make a change to use it instead?I'm willing to contribute the code if you will
The text was updated successfully, but these errors were encountered: