-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tauri-plugin-opener
#2019
Conversation
marking as a draft until I release an empty packages on crates.io and npm |
Package Changes Through 23143e9There are 12 changes which include upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, log-plugin with patch, log-js with patch, fs with patch, fs-js with patch, localhost with minor, opener with major, opener-js with major, sql with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is fixed in this PR
It still seem to happen in this PR to me
weird, I can reproduce in this PR, anyways I am looking into it, seems not related to the implementation, might be a bug in tauri, still searching... |
fixed |
Need to get some sleep, will get back to this tomorrow |
Co-authored-by: Tony <[email protected]>
double events are fixed in tauri-apps/wry#1418, so this PR can move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only tested on Windows though
@FabianLars can you give this a test on macOS? (and Linux if you want) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well on macos and wsl (don't have an actual linux system on hand rn)
closes #999
closes #1045