fix: improve binding validation#1739
Merged
midhunadarvin merged 16 commits intoBuilderIO:mainfrom Jun 27, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 520005a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 520005a.
☁️ Nx Cloud last updated this comment at |
liamdebeasi
commented
Jun 26, 2025
liamdebeasi
commented
Jun 26, 2025
liamdebeasi
commented
Jun 26, 2025
liamdebeasi
commented
Jun 26, 2025
liamdebeasi
commented
Jun 26, 2025
Contributor
Author
liamdebeasi
left a comment
There was a problem hiding this comment.
overall looks good! a few small comments. you'll need to get an approval from someone other than me since I'm the PR author
This reverts commit 6a9b42c.
samijaber
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The invalid binding detection misses code that is valid JS but is not a valid binding such as
export default foo. This PR improves the detection by checking if the code can be used as a binding when passed into babel.I'm also using the
parseCodeutil now because it has presets that are needed to parse JSX/TSX.Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.