fix: issues for vue composition api #1558
Conversation
🦋 Changeset detectedLatest commit: 6c6d479 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c6d479. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
your replaceNodes call isn't working properly. 🤔
might want to add some unit tests in https://github.com/BuilderIO/mitosis/blob/main/packages/core/src/helpers/replace-identifiers.test.ts
to figure out why that is.
| valueMapper: (code, _, typeParameter) => { | ||
| const cleanCode = code.replaceAll('this.', ''); // Composition api isn't a class we don't need "this." here | ||
| return isTs && typeParameter ? `ref<${typeParameter}>(${cleanCode})` : `ref(${cleanCode})`; | ||
| }, |
There was a problem hiding this comment.
| valueMapper: (code, _, typeParameter) => { | |
| const cleanCode = code.replaceAll('this.', ''); // Composition api isn't a class we don't need "this." here | |
| return isTs && typeParameter ? `ref<${typeParameter}>(${cleanCode})` : `ref(${cleanCode})`; | |
| }, |
There was a problem hiding this comment.
oh sorry i meant to suggest reverting
| valueMapper: (code, _, typeParameter) => { | |
| const cleanCode = code.replaceAll('this.', ''); // Composition api isn't a class we don't need "this." here | |
| return isTs && typeParameter ? `ref<${typeParameter}>(${cleanCode})` : `ref(${cleanCode})`; | |
| }, | |
| valueMapper: (code, _, typeParameter) => | |
| isTs && typeParameter ? `ref<${typeParameter}>(${code})` : `ref(${code})`, |
| "type": "property", | ||
| }, | ||
| "_messageId": { | ||
| "code": "this._id + \\"-message\\"", |
There was a problem hiding this comment.
it doesn't seem like your replaceNodes logic works properly. this should be state.id.
| "<script> | ||
| let _id = \\"abc\\"; | ||
|
|
||
| let _messageId = this._id + \\"-message\\"; |
There was a problem hiding this comment.
another indicator that the replaceNodes isn't doing its job
Co-authored-by: Sami Jaber <[email protected]>
# Conflicts: # packages/core/src/__tests__/__snapshots__/stencil.test.ts.snap
| @@ -220,6 +216,9 @@ export const replaceNodes = ({ | |||
| }; | |||
|
|
|||
| return babelTransformExpression(code, { | |||
| ThisExpression(path) { | |||
| searchAndReplace(path); | |||
| }, | |||
|
Looks like you have some issues with your Solid and Marko tests: when tests go from throwing to no longer throwing, if |
Description
Please provide the following information:
There were some issues with vue
option.api="composition":refwasn't imported when usinguseRefhook without usinguseStateref()wihtout anyclass-> we don't needthis., but we always use.valuerefcould benullforuseRefsee: https://vuejs.org/guide/essentials/template-refs.html#accessing-the-refsMake sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.