feat: refactor stencil generator to work properly with current version #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44da19c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 44da19c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
3 tasks
5 tasks
|
@samijaber Can I do anything else to support you with this? |
samijaber
reviewed
Sep 25, 2024
samijaber
reviewed
Sep 25, 2024
chore: update changeset with angular comment
samijaber
requested changes
Sep 26, 2024
3 tasks
# Conflicts: # packages/core/src/generators/stencil/generate.ts # packages/core/src/generators/stencil/types.ts # packages/core/src/types/metadata.ts
samijaber
approved these changes
Sep 30, 2024
packages/core/src/generators/stencil/plugins/get-code-processor-plugins.ts
Outdated
Show resolved
Hide resolved
|
you have a merge conflict |
# Conflicts: # packages/core/src/__tests__/test-generator.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide the following information:
Refactored Stencil generator to work with current Version.
The previous generator didn't work with all tests/examples.
closes #1251
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.