fix[react-gen1]: handle fetchPriority vs fetchpriority in different react versions
#4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 611deab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 611deab
☁️ Nx Cloud last updated this comment at |
sanyamkamat
reviewed
Sep 29, 2025
packages/react/src/blocks/Image.tsx
Outdated
| get fetchPriorityProp() { | ||
| const propNameToUse = isNewReact ? 'fetchPriority' : 'fetchpriority'; | ||
| return { | ||
| [propNameToUse]: this.props.highPriority ? 'high' : 'auto', |
Contributor
There was a problem hiding this comment.
The previous logic for this value was
const eagerLoad = isPixel || this.props.highPriority;
Do we need to add isPixel check here?
Contributor
Author
There was a problem hiding this comment.
thanks for the catch, i've updated it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles fetch priority casing based on React versions
Inspiration from:
facebook/react#28946
vercel/next.js#65235
ascorbic/unpic-img#644
Screenshot
If relevant, add a screenshot or two of the changes you made.