Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[gen1][core] ENG-7238 remove query API and apiEndpoint field #3681

Merged
merged 12 commits into from
Oct 31, 2024

Conversation

clyde-builderio
Copy link
Contributor

@clyde-builderio clyde-builderio commented Oct 25, 2024

Description

Remove query API for Gen1 SDK

Objectives:

  1. Remove query API from Gen1 SDK.
  2. Remove apiEndpoint and the code that depends on this field as an input.
  3. Remove unwanted tests and modify existing tests.

Link to JIRA ticket:
https://builder-io.atlassian.net/browse/ENG-7238

@clyde-builderio clyde-builderio requested a review from a team as a code owner October 25, 2024 10:16
@clyde-builderio clyde-builderio requested review from samijaber and removed request for a team October 25, 2024 10:16
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 811205d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/sdk Major
@builder.io/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/pink-fans-serve.md Outdated Show resolved Hide resolved
@clyde-builderio clyde-builderio merged commit f4fffe9 into BuilderIO:main Oct 31, 2024
48 checks passed
samijaber added a commit to samijaber/builder that referenced this pull request Nov 17, 2024
samijaber added a commit that referenced this pull request Nov 17, 2024
This reverts commit f4fffe9 (#3681) and
allows using `/query` again to fix React SDK.

v6 (showing wrong symbol):  
![CleanShot 2024-11-17 at 14 38
47@2x](https://github.com/user-attachments/assets/eeb0d228-0c7f-4d7a-881b-99c2d2e87355)


v7.0.0-0 (dev) showing correct symbol:
<img width="2192" alt="image"
src="https://github.com/user-attachments/assets/6e314c4b-b2a2-4913-a0fb-5f43f9a34234">



https://builder-io.atlassian.net/browse/ENG-7483
@builderio-bot builderio-bot mentioned this pull request Nov 17, 2024
samijaber pushed a commit that referenced this pull request Nov 17, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @builder.io/[email protected]

### Major Changes

- f12f43d: Breaking Change: Use `/query` instead of `/content` for API
calls. This change fixes a symbol rendering issue introduced in
<#3681>, which was included in
the 4.0.0 release.

## @builder.io/[email protected]

### Major Changes

- f12f43d: Breaking Change: Use `/query` instead of `/content` for API
calls. This change fixes a symbol rendering issue introduced in
<#3681>, which was included in
the 6.0.0 release.

### Patch Changes

-   Updated dependencies [f12f43d]
    -   @builder.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants