Updating Visual Diff Goldens for PR 3881 #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
svanherk
force-pushed
the
DE54475_Add_test_demos_show_sticky_list_controls_scroll_issue
branch
from
3f33cef to
4d81420
Compare
github-actions
bot
force-pushed
the
ghworkflow/visual-diff-pr-3881
branch
from
1759398 to
6e0dab7
Compare
github-actions
bot
force-pushed
the
ghworkflow/visual-diff-pr-3881
branch
from
6e0dab7 to
0857d7b
Compare
|
Looks as I expected - slight changes from changing the padding, and some new diffs that don't look great (but that's the point!) |
svanherk
merged commit 81212d6
into
DE54475_Add_test_demos_show_sticky_list_controls_scroll_issue
svanherk
added a commit
that referenced
this pull request
Aug 21, 2023
* Add list visual-diffs and dialog demos to show the sticky list controls + scroll issue * Updating Visual Diff Goldens (#3882) Co-authored-by: github-actions <[email protected]> * Fix sticky d2l-list-controls width * Updating Visual Diff Goldens (#3900) Co-authored-by: github-actions <[email protected]> * Ignore length-zero-no-unit style linting rule for css variable that will be used in calc * Avoid having to set the css variable in Javascript * Revert Avoid having to set the css variable in Javascript --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]>
svanherk
added a commit
that referenced
this pull request
Aug 21, 2023
* Add list visual-diffs and dialog demos to show the sticky list controls + scroll issue * Updating Visual Diff Goldens (#3882) Co-authored-by: github-actions <[email protected]> * Fix sticky d2l-list-controls width * Updating Visual Diff Goldens (#3900) Co-authored-by: github-actions <[email protected]> * Ignore length-zero-no-unit style linting rule for css variable that will be used in calc * Avoid having to set the css variable in Javascript * Revert Avoid having to set the css variable in Javascript --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> (cherry picked from commit 6b6501e)
svanherk
added a commit
that referenced
this pull request
Aug 21, 2023
) (This is a backport of #3899) * Add list visual-diffs and dialog demos to show the sticky list controls + scroll issue * Updating Visual Diff Goldens (#3882) Co-authored-by: github-actions <[email protected]> * Fix sticky d2l-list-controls width * Updating Visual Diff Goldens (#3900) Co-authored-by: github-actions <[email protected]> * Ignore length-zero-no-unit style linting rule for css variable that will be used in calc * Avoid having to set the css variable in Javascript * Revert Avoid having to set the css variable in Javascript --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]> (cherry picked from commit 6b6501e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the visual-diff golden images for the changes in pull request #3881.
Please review the following failed reports closely before merging to ensure the visual differences are expected.
Failed Reports: