DE54475 - Add test and demos to show sticky d2l-list-controls scrolled + list hover/focus issue #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanherk
commented
Aug 8, 2023
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
|
Visual diff tests failed - pull request #3882 has been opened with the updated goldens. |
svanherk
changed the title
svanherk
changed the title
…ls + scroll issue
svanherk
force-pushed
the
DE54475_Add_test_demos_show_sticky_list_controls_scroll_issue
branch
from
3f33cef to
4d81420
Compare
…rols_scroll_issue
Co-authored-by: github-actions <[email protected]>
svanherk
changed the title
svanherk
deleted the
DE54475_Add_test_demos_show_sticky_list_controls_scroll_issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up the visual-diff list tests and dialog demo to show the issue, which will be fixed in a follow-up PR.
I was having a horrible time trying to get hover working properly for lists in dialog with the old
visual-diff. I'm going to put up a PR moving the dialog tests to the newvdiff.