Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding of WXXX frames #454

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix decoding of WXXX frames #454

merged 1 commit into from
Mar 10, 2020

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Mar 10, 2020

Fixes #453.

@Borewit Borewit added the bug Bug, will addressed with high priority label Mar 10, 2020
@Borewit Borewit self-assigned this Mar 10, 2020
@Borewit Borewit merged commit d71ea6c into master Mar 10, 2020
@Borewit
Copy link
Owner Author

Borewit commented Mar 10, 2020

Part of v6.3.5

@Quppa
Copy link

Quppa commented Mar 11, 2020

I think the other URL link frames (W000 to WZZZ) should be treated in the same way. Mp3tag definitely writes ISO-8859-1 for WOAR (WWWARTIST in their list).

@Borewit Borewit mentioned this pull request Mar 11, 2020
Closed
@Borewit Borewit deleted the fix-WXXX-decoding branch March 11, 2020 07:11
@Borewit
Copy link
Owner Author

Borewit commented Mar 11, 2020 •
edited
Loading

I think the other URL link frames (W000 to WZZZ) should be treated in the same way. Mp3tag definitely writes ISO-8859-1 for WOAR (WWWARTIST in their list).

I think you are right @Quppa, thanks for pointing that out. Fixed in v6.3.6 via PR #456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID3v2.3 WXXX (URL) tags parsed incorrectly as UCS-2
2 participants
@Borewit @Quppa