Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3v2.3 WXXX (URL) tags parsed incorrectly as UCS-2 #453

Closed
Borewit opened this issue Mar 10, 2020 · 1 comment · Fixed by #454
Closed

ID3v2.3 WXXX (URL) tags parsed incorrectly as UCS-2 #453

Borewit opened this issue Mar 10, 2020 · 1 comment · Fixed by #454
Labels
bug Bug, will addressed with high priority

Comments

@Borewit
Copy link
Owner

Borewit commented Mar 10, 2020

Same issue as reported in aadsm/jsmediatags#126

In version 3.9.3 WXXX (URL) ID3v2.3 tags are being parsed incorrectly as UCS-2 rather than ISO-8859-1. From the spec:

All numeric strings and URLs are always encoded as ISO-8859-1.

Example bytes of a WXXX tag where user_description should be 'あ' (UCS-2 encoded) and data should be https://www.example.com:
57 58 58 58 00 00 00 1E 00 00 01 FF FE 42 30 00 00 68 74 74 70 73 3A 2F 2F 77 77 77 2E 65 78 61 6D 70 6C 65 2E 63 6F 6D

I think the issue was introduced with this change: #120

Repro: https://codepen.io/Quppa/pen/yLNbPpX

Example MP3 (contains just TIT2 and WXXX):
jsmediatags.zip

@Borewit Borewit added the bug Bug, will addressed with high priority label Mar 10, 2020
Borewit added a commit that referenced this issue Mar 10, 2020
@Borewit
Copy link
Owner Author

Borewit commented Mar 10, 2020

Fixed in v6.3.5

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant