Conversation
Bug Fixes
Contributorshallipr, azure-sdk, rhorber, drielenr, rajkumar-rangaraj, TimothyMothra, ArcturusZhang, jsquire, williamzhao87, JoshLove-msft, amnguye, paulroho, joseharriaga, trrwilson, m-nash, jalauzon-msft, archerzz Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
@pull-request-quantifier[bot] is not allowed to run commands |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
25 similar comments
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
* Add azure-sdk-pr-review skill to .github/skills/ Move the azure-sdk-pr-review Copilot skill from local user skills to the repository .github/skills/ directory so it is available to all contributors. * Address PR review feedback - Rename skill to azure-sdk-mgmt-pr-review to reflect management-plane scope - Clarify packages are under Azure.ResourceManager.* - Reference TypeSpec (client.tsp, tspconfig.yaml) instead of only autorest.md - Update output format to add comments directly to PR via GitHub MCP tools * Remove legacy autorest.md references * Address copilot reviewer feedback - Include Azure.ResourceManager (base package) in scope - Clarify Type Formatting table for .NET API surface (Guid not uuid) - Add TypeSpec note for UUID mapping
….0.0-alpha.20260211.1 (#56186) * Regenerate repository SDK with TypeSpec build 20260211.1 * Update SDK code re_wo_4 * Update SDK code co_ed_1 * export API --------- Co-authored-by: Arthur Ma <mars.arthur@263.net> Co-authored-by: Wei Hu <huwe@microsoft.com>
…alpha.20260211.1 (#56194) * Regenerate repository SDK with TypeSpec build 20260211.1 * Update SDK code mo_re_3 * Update SDK code ed_mo_2 * Update SDK code re_wo_4 * Update SDK code co_ed_1 * Update SDK code ad_co_0 * update snippets * update more snippets --------- Co-authored-by: Jorge Rangel <jorgerangel@microsoft.com>
Updating to correct label.
* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260212.3 * fix tests --------- Co-authored-by: Ubuntu <cloudtest@6dd5f444c000002.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net> Co-authored-by: Jorge Rangel <jorgerangel@microsoft.com>
…6236) Resolves #55501 - Add configurable WorkloadIdentityCredential tests that create credentials via IConfiguration and ConfigurableCredential instead of direct instantiation - Add creation tests for all 7 credential types validating option priority: IConfiguration > environment variable > default - Plumb IsAzureProxyEnabled through DefaultAzureCredentialOptions for WIC proxy support - Add shared CredentialCreationTestBase<T> with reflection helpers - Simplify helper by exposing config mapping and transport support
Co-authored-by: Matthew Sainsbury <msainsbury@microsoft.com>
* remove limits on application id length * take 2 * take 3 * fix ifs * update implementation * tweak implementation 2 * undo test change * fix ctor * tests * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feedback * add a minimum * take 3 * self review * handle a couple gaps * first pass on changing back to client options * delay validation an remove max * review * update test * remove old tests * remove config * remove eager validation test from old implementation * fix --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: add xml serialization visitor * pr feedback
…se 1.0.0-alpha.20260211.2 (#56217) * Regenerate repository SDK with TypeSpec build 20260211.2 * Update SDK code co_ed_1 * Update SDK code ed_mo_2 * Update SDK code re_wo_4 * Update SDK code mo_re_3 * Update SDK code ad_co_0 * update snippet --------- Co-authored-by: azure-sdk <azuresdk@microsoft.com>
* Initial plan * Fix CredentialSettings constructor to not throw for non-auth clients Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com>
* Update UnbrandedGeneratorVersion to 1.0.0-alpha.20260212.5 * Fix InvalidOperationException in pagination when services return relative nextLink URIs (#56249) * Initial plan * Fix relative URI handling in pagination - use IsAbsoluteUri check Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Revert Spector and package-lock.json changes Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> --------- Co-authored-by: Ubuntu <cloudtest@ff2ffbe4c000001.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
* Updated deployment setting to use http * Use parameters.AdditionalParameters in yaml --------- Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
…eration - .NET-5867191 (#56188)
…preserving Authorization header (#55633) * Add redirect policy to CodeTransparency and ConfidentialLedger SDKs - Add CodeTransparencyRedirectPolicy to follow 307/308 redirects while preserving Authorization header - Wire redirect policy into CodeTransparencyClient constructor - Add unit tests for CodeTransparencyRedirectPolicy (11 tests) - Update CodeTransparency CHANGELOG.md - Update ConfidentialLedger CHANGELOG.md version to 1.4.1-beta.3 * update changelog * fix pipeline * fix pipeline * Update sdk/confidentialledger/Azure.Security.CodeTransparency/CHANGELOG.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update sdk/confidentialledger/Azure.Security.CodeTransparency/src/CodeTransparencyRedirectPolicy.cs Co-authored-by: Andrea Piccione <and.piccione@gmail.com> * Update sdk/confidentialledger/Azure.Security.CodeTransparency/src/CodeTransparencyRedirectPolicy.cs Co-authored-by: Andrea Piccione <and.piccione@gmail.com> * Update sdk/confidentialledger/Azure.Security.CodeTransparency/src/CodeTransparencyRedirectPolicy.cs Co-authored-by: Andrea Piccione <and.piccione@gmail.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrea Piccione <and.piccione@gmail.com>
Co-authored-by: Ubuntu <cloudtest@758eeaa5c000004.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
) * Support credential instance reuse in WithAzureCredential DI path (#56231) * Refactor credential cache: encapsulate key creation in GetOrAdd and simplify to StringBuilder * Share credential cache globally across DI and direct ClientSettings paths with lazy initialization
…alpha.20260213.1 (#56272) * Regenerate repository SDK with TypeSpec build 20260213.1 * Update SDK code ed_mo_2 * Update SDK code co_ed_1 * Update SDK code re_wo_4 * Update SDK code mo_re_3 * Update SDK code ad_co_0
Co-authored-by: Ubuntu <cloudtest@8c6b791ec000002.tkkhlgj2u51eln3mcb0lygmbye.dx.internal.cloudapp.net>
* migrate AnomalyDetector * Migrate to new generator * Regeneration after Endpoint is changed from string to url in main.tsp * fix tests * change commit to latest * changes after running update snippets and export API scripts * Generator migration script * rerun Library_Inventory.ps1 * Regenerate anomalydetector SDK serialization code * Regenerate anomalydetector serialization code to match current generator output * rerun library inventory script --------- Co-authored-by: Linh Phan <mailinhphan@microsoft.com>
* Add bump-mgmt-base-version Copilot skill Adds a reusable Copilot skill for bumping the http-client-csharp base dependency version in http-client-csharp-mgmt. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix step numbering in skill file Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Updates @azure-typespec/http-client-csharp and AzureGeneratorVersion from 1.0.0-alpha.20260209.2 to 1.0.0-alpha.20260213.2. Includes prettier fixes and regenerated test projects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Regenerate SDK from spec commit 1d0c547 and fix tests - Regenerate SDK code using tsp-client update with local spec repo - Update typed response models (AssetStatisticsResponse, QueryableDefinitionsResponse, TilerAssetGeoJson) - Fix test and sample compilation: use .AdditionalProperties for dictionary access - Update tsp-location.yaml to spec commit 1d0c54799082b9cbe46d984069f673b7013b3c59 - Update public API listings * Generate API
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )