Skip to content

Conversation

@pavlenex
Copy link
Contributor

@pavlenex pavlenex commented Jan 11, 2021

This PR is a successor of #103 due to changes that will happen in #108

Overview

This PR:

  • Creates a new section Contribute
  • Moves certain part of Resources to Contribute (including images)
  • Creates a new Contribute.md in the contribute and in the folder, that should serve as the starting page.
  • Edits content in Content Guidelines.md (condenses info, grammar fixes and new content, quite re-structured but not from the grounds up)
  • Edits and formats "Formatting.md`

@pavlenex
Copy link
Contributor Author

pavlenex commented Jan 12, 2021

This PR should now be ready for a review.

There are few more things left, that I'd like to tackle in a separate PR, to keep changes to minimal so that this or other pull requests don't require larger rebasing.

To-Do

If this PR gets merged, I will do following things in the next one:

  • Create "How to submit.md" as per discussion here
  • Create "target-audience.md` and add link to Google Doc in progress
  • Add example template when creating a brand-new page.

Consequence of this PR

Also feel free to squash the commits when merging, I may have over-done it as I tried to fix few visual things.

Copy link
Contributor

@johnsBeharry johnsBeharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Awesome work @pavlenex and very much needed.

Apply GBKS's suggestions.

Co-authored-by: Christoph Ono <[email protected]>
@pavlenex
Copy link
Contributor Author

@johnsBeharry I've committed @GBKS's suggestions. Should be good to go now, but we may want #108 merged in first ,so that I can re-base if needed.

@GBKS GBKS merged commit da2ff14 into BitcoinDesign:master Jan 13, 2021
johnsBeharry pushed a commit that referenced this pull request Jan 16, 2021
* Set up foundation resources vs contribute

* Update formatting.md

* add contribute.md

* Update content-guidelines.md

* Update contribute.md

* add examples do's and don't

* formatting

* replace blockquote with italic styling

* add example of graphical context

* Add better structure to formatting with examples

* Update formatting.md

* re-structure and add lists

* image formatting

* re-structure

* add html tag

* Update formatting.md

* try plaintext

* replace html with markdown

* Update content-guidelines.md

* better link example

* add yt video instructions

* liquid raw format, remove encoded img code

* attempt to fix {% raw %}

* Added Contribute page preview image

* Apply suggestions from code review

Apply GBKS's suggestions.

Co-authored-by: Christoph Ono <[email protected]>

* Apply suggestions from code review

Co-authored-by: Christoph Ono <[email protected]>

* Remove Resources.md and img folder

* add footnote, fix figma, move code block

* Update formatting.md

* Add minimal info on slack channel and github to guide contribution page

* Change nav title to 'Contribute to Guide'

* Make *the* reader....

* Bump subheader formatting to differentiate from Do's/Dont's

* Put 'Do's ahead of 'Don't's

* *most* people *scan*...

* Simplify language

* Tweaks to language

* tweaks, add reference to markdown.

* Revert "tweaks, add reference to markdown."

This reverts commit 6b0ed53.

* Break

* Typos

* Figma embed tweaks.

* Footnote tweaks

* are you -> you are

* Revert nav title change (too long)

* Revert "Revert nav title change (too long)"

This reverts commit f405401.

* Fix parent names

* Update guide/contribute/contribute.md

Co-authored-by: Christoph Ono <[email protected]>

* Update guide/contribute/contribute.md

Co-authored-by: Christoph Ono <[email protected]>

* Update guide/contribute/contribute.md

Co-authored-by: Christoph Ono <[email protected]>

* Fix parent:

Co-authored-by: Pavlenex <[email protected]>
Co-authored-by: GBKS <[email protected]>
Co-authored-by: Daniel Nordh <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants